From: Zeev Suraski <zeev@php.net>
Date: Mon, 14 Mar 2005 12:53:34 +0000 (+0000)
Subject: Clarify logic
X-Git-Tag: php-5.0.1b1~799
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=1dbc47c43f3bf34cc642a4b79bac9e60d20128bd;p=php

Clarify logic
---

diff --git a/Zend/zend_ini.c b/Zend/zend_ini.c
index e43ecbb833..90ef3406fc 100644
--- a/Zend/zend_ini.c
+++ b/Zend/zend_ini.c
@@ -447,10 +447,10 @@ ZEND_API ZEND_INI_MH(OnUpdateBool)
 
 	p = (zend_bool *) (base+(size_t) mh_arg1);
 
-	if (strncasecmp("on", new_value, sizeof("on"))) {
-		*p = (zend_bool) atoi(new_value);
-	} else {
+	if (new_value_length==2	&& strcasecmp("on", new_value)==0) {
 		*p = (zend_bool) 1;
+	} else {
+		*p = (zend_bool) atoi(new_value);
 	}
 	return SUCCESS;
 }