From: Dmitry Stogov <dmitry@php.net>
Date: Thu, 10 Jan 2008 09:38:41 +0000 (+0000)
Subject: Added missing warning message
X-Git-Tag: RELEASE_2_0_0a1~961
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=1d9894a0c52806f152d1b310eca88784a7cdd373;p=php

Added missing warning message
---

diff --git a/Zend/zend_execute_API.c b/Zend/zend_execute_API.c
index ff404df7e7..7c764bed90 100644
--- a/Zend/zend_execute_API.c
+++ b/Zend/zend_execute_API.c
@@ -1058,6 +1058,11 @@ int zend_call_function(zend_fcall_info *fci, zend_fcall_info_cache *fci_cache TS
 						zval_ptr_dtor(&method_name);
 						zval_ptr_dtor(&params_array);
 					}
+					zend_error(E_WARNING, "Parameter %d to %v%s%v() expected to be a reference, value given",
+						i+1,
+						EX(function_state).function->common.scope ? EX(function_state).function->common.scope->name : EMPTY_ZSTR,
+						EX(function_state).function->common.scope ? "::" : "",
+						EX(function_state).function->common.function_name);
 					return FAILURE;
 				}
 				ALLOC_ZVAL(new_zval);
diff --git a/ext/reflection/tests/bug42976.phpt b/ext/reflection/tests/bug42976.phpt
index 38aed3a400..9576f4f5d2 100644
--- a/ext/reflection/tests/bug42976.phpt
+++ b/ext/reflection/tests/bug42976.phpt
@@ -26,9 +26,26 @@ echo "Done\n";
 --EXPECTF--	
 string(9) "x.changed"
 
-Warning: Invocation of C's constructor failed in %s/bug42976.php on line %d
+Warning: Parameter 1 to C::__construct() expected to be a reference, value given in %sbug42976.php on line 15
+
+Warning: Invocation of C's constructor failed in %sbug42976.php on line 15
 string(10) "x.original"
 
-Warning: Invocation of C's constructor failed in %s/bug42976.php on line %d
+Warning: Parameter 1 to C::__construct() expected to be a reference, value given in %sbug42976.php on line 18
+
+Warning: Invocation of C's constructor failed in %sbug42976.php on line 18
 string(10) "x.original"
 Done
+--UEXPECTF--	
+unicode(9) "x.changed"
+
+Warning: Parameter 1 to C::__construct() expected to be a reference, value given in %sbug42976.php on line 15
+
+Warning: Invocation of C's constructor failed in %sbug42976.php on line 15
+unicode(10) "x.original"
+
+Warning: Parameter 1 to C::__construct() expected to be a reference, value given in %sbug42976.php on line 18
+
+Warning: Invocation of C's constructor failed in %sbug42976.php on line 18
+unicode(10) "x.original"
+Done
diff --git a/ext/standard/tests/general_functions/bug41970.phpt b/ext/standard/tests/general_functions/bug41970.phpt
index cc942ffa64..17461a312b 100644
--- a/ext/standard/tests/general_functions/bug41970.phpt
+++ b/ext/standard/tests/general_functions/bug41970.phpt
@@ -12,13 +12,16 @@ var_dump(call_user_func("strlen", $a));
 
 echo "Done\n";
 ?>
---EXPECTF--	
+--EXPECTF--
+Warning: Parameter 1 to sort() expected to be a reference, value given in %sbug41970.php on line 5
 NULL
 
-Notice: Array to string conversion in %s on line %d
+Notice: Array to string conversion in %sbug41970.php on line 6
 int(5)
+
+Warning: Parameter 1 to sort() expected to be a reference, value given in %sbug41970.php on line 7
 NULL
 
-Notice: Array to string conversion in %s on line %d
+Notice: Array to string conversion in %sbug41970.php on line 8
 int(5)
 Done