From: Hirokazu Yamamoto <ocean-city@m2.ccsnet.ne.jp>
Date: Tue, 31 Mar 2009 20:14:04 +0000 (+0000)
Subject: Issue #5387: Fixed mmap.move crash by integer overflow. (take2)
X-Git-Tag: v2.7a1~1679
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=1d7d5325be5c766c3446dcf0fce4ebce73d83fa7;p=python

Issue #5387: Fixed mmap.move crash by integer overflow. (take2)
---

diff --git a/Lib/test/test_mmap.py b/Lib/test/test_mmap.py
index b8998ea13d..1a23f2e467 100644
--- a/Lib/test/test_mmap.py
+++ b/Lib/test/test_mmap.py
@@ -1,6 +1,6 @@
 from test.test_support import TESTFN, run_unittest, import_module
 import unittest
-import os, re
+import os, re, itertools
 
 mmap = import_module('mmap')
 
@@ -351,9 +351,21 @@ class MmapTests(unittest.TestCase):
                     self.assertEqual(m[:], expected)
                     m.close()
 
-        # should not crash
-        m = mmap.mmap(-1, 1)
-        self.assertRaises(ValueError, m.move, 1, 1, -1)
+        # segfault test (Issue 5387)
+        m = mmap.mmap(-1, 100)
+        offsets = [-100, -1, 0, 1, 100]
+        for source, dest, size in itertools.product(offsets, offsets, offsets):
+            try:
+                m.move(source, dest, size)
+            except ValueError:
+                pass
+        self.assertRaises(ValueError, m.move, -1, -1, -1)
+        self.assertRaises(ValueError, m.move, -1, -1, 0)
+        self.assertRaises(ValueError, m.move, -1, 0, -1)
+        self.assertRaises(ValueError, m.move, 0, -1, -1)
+        self.assertRaises(ValueError, m.move, -1, 0, 0)
+        self.assertRaises(ValueError, m.move, 0, -1, 0)
+        self.assertRaises(ValueError, m.move, 0, 0, -1)
         m.close()
 
     def test_anonymous(self):
diff --git a/Modules/mmapmodule.c b/Modules/mmapmodule.c
index bd7f7cc888..cbacc2fc25 100644
--- a/Modules/mmapmodule.c
+++ b/Modules/mmapmodule.c
@@ -617,7 +617,7 @@ mmap_move_method(mmap_object *self, PyObject *args)
 	} else {
 		/* bounds check the values */
 		unsigned long pos = src > dest ? src : dest;
-		if (self->size >= pos && count > self->size - pos) {
+		if (self->size < pos || count > self->size - pos) {
 			PyErr_SetString(PyExc_ValueError,
 					"source or destination out of range");
 			return NULL;