From: Supreet Deshpande <supreet.deshpande@espressif.com>
Date: Mon, 17 Dec 2018 04:26:18 +0000 (+0530)
Subject: bugfix/ota_magic_byte_issue: Fix indent and replace constant by macro
X-Git-Tag: v3.3-beta2~171^2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=1d4bb7cc4de6e20a1f88177985c53a460362b95d;p=esp-idf

bugfix/ota_magic_byte_issue: Fix indent and replace constant by macro

Replace 0xE9 by ESP_IMAGE_HEADER_MAGIC.
---

diff --git a/components/app_update/esp_ota_ops.c b/components/app_update/esp_ota_ops.c
index 40cd89d49c..6e8998d323 100644
--- a/components/app_update/esp_ota_ops.c
+++ b/components/app_update/esp_ota_ops.c
@@ -183,7 +183,7 @@ esp_err_t esp_ota_write(esp_ota_handle_t handle, const void *data, size_t size)
         if (it->handle == handle) {
             // must erase the partition before writing to it
             assert(it->erased_size > 0 && "must erase the partition before writing to it");
-            if(it->wrote_size == 0 && it->partial_bytes == 0 && size > 0 && data_bytes[0] != 0xE9) {
+            if (it->wrote_size == 0 && it->partial_bytes == 0 && size > 0 && data_bytes[0] != ESP_IMAGE_HEADER_MAGIC) {
                 ESP_LOGE(TAG, "OTA image has invalid magic byte (expected 0xE9, saw 0x%02x", data_bytes[0]);
                 return ESP_ERR_OTA_VALIDATE_FAILED;
             }