From: Côme Chilliet <mcmic@php.net>
Date: Mon, 28 Sep 2020 12:52:40 +0000 (+0200)
Subject: Rename $link parameters to $ldap in ldap functions
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=1d3787ee94d261d3194d70b85382467995dcc7eb;p=php

Rename $link parameters to $ldap in ldap functions

Also fixed ldap_set_option places where $newvalue was still used
---

diff --git a/ext/ldap/ldap.c b/ext/ldap/ldap.c
index 1f99e20720..13ea7647fc 100644
--- a/ext/ldap/ldap.c
+++ b/ext/ldap/ldap.c
@@ -1601,12 +1601,12 @@ cleanup_parallel:
 		}
 
 		if (!base_dn_str) {
-			zend_argument_type_error(2, "must be of type string when argument #1 ($link_identifier) is a resource");
+			zend_argument_type_error(2, "must be of type string when argument #1 ($ldap) is a resource");
 		}
 		ldap_base_dn = zend_string_copy(base_dn_str);
 
 		if (!filter_str) {
-			zend_argument_type_error(3, "must be of type string when argument #1 ($link_identifier) is a resource");
+			zend_argument_type_error(3, "must be of type string when argument #1 ($ldap) is a resource");
 		}
 		ldap_filter = zend_string_copy(filter_str);
 
diff --git a/ext/ldap/ldap.stub.php b/ext/ldap/ldap.stub.php
index a5233f473e..cd0cfb6bf6 100644
--- a/ext/ldap/ldap.stub.php
+++ b/ext/ldap/ldap.stub.php
@@ -10,256 +10,256 @@ function ldap_connect(?string $uri = null, int $port = 389, string $wallet = UNK
 function ldap_connect(?string $uri = null, int $port = 389) {}
 #endif
 
-/** @param resource $link */
-function ldap_unbind($link): bool {}
+/** @param resource $ldap */
+function ldap_unbind($ldap): bool {}
 
 /**
- * @param resource $link
+ * @param resource $ldap
  * @alias ldap_unbind
  */
-function ldap_close($link): bool {}
+function ldap_close($ldap): bool {}
 
-/** @param resource $link */
-function ldap_bind($link, ?string $dn = null, ?string $password = null): bool {}
+/** @param resource $ldap */
+function ldap_bind($ldap, ?string $dn = null, ?string $password = null): bool {}
 
 /**
- * @param resource $link
+ * @param resource $ldap
  * @return resource|false
  */
-function ldap_bind_ext($link, ?string $dn = null, ?string $password = null, array $controls = []) {}
+function ldap_bind_ext($ldap, ?string $dn = null, ?string $password = null, array $controls = []) {}
 
 #ifdef HAVE_LDAP_SASL
-/** @param resource $link */
-function ldap_sasl_bind($link, ?string $dn = null, ?string $password = null, ?string $mech = null, ?string $realm = null, ?string $authc_id = null, ?string $authz_id = null, ?string $props = null): bool {}
+/** @param resource $ldap */
+function ldap_sasl_bind($ldap, ?string $dn = null, ?string $password = null, ?string $mech = null, ?string $realm = null, ?string $authc_id = null, ?string $authz_id = null, ?string $props = null): bool {}
 #endif
 
 /**
- * @param resource|array $link
+ * @param resource|array $ldap
  * @return resource|false
  */
-function ldap_read($link, array|string $base, array|string $filter, array $attributes = [], int $attrsonly = 0, int $sizelimit = -1, int $timelimit = -1, int $deref = LDAP_DEREF_NEVER, array $controls = []) {}
+function ldap_read($ldap, array|string $base, array|string $filter, array $attributes = [], int $attrsonly = 0, int $sizelimit = -1, int $timelimit = -1, int $deref = LDAP_DEREF_NEVER, array $controls = []) {}
 
 /**
- * @param resource|array $link
+ * @param resource|array $ldap
  * @return resource|false
  */
-function ldap_list($link, array|string $base, array|string $filter, array $attributes = [], int $attrsonly = 0, int $sizelimit = -1, int $timelimit = -1, int $deref = LDAP_DEREF_NEVER, array $controls = []) {}
+function ldap_list($ldap, array|string $base, array|string $filter, array $attributes = [], int $attrsonly = 0, int $sizelimit = -1, int $timelimit = -1, int $deref = LDAP_DEREF_NEVER, array $controls = []) {}
 
 /**
- * @param resource|array $link
+ * @param resource|array $ldap
  * @return resource|false
  */
-function ldap_search($link, array|string $base, array|string $filter, array $attributes = [], int $attrsonly = 0, int $sizelimit = -1, int $timelimit = -1, int $deref = LDAP_DEREF_NEVER, array $controls = []) {}
+function ldap_search($ldap, array|string $base, array|string $filter, array $attributes = [], int $attrsonly = 0, int $sizelimit = -1, int $timelimit = -1, int $deref = LDAP_DEREF_NEVER, array $controls = []) {}
 
-/** @param resource $link */
-function ldap_free_result($link): bool {}
+/** @param resource $ldap */
+function ldap_free_result($ldap): bool {}
 
 
 /**
- * @param resource $link
+ * @param resource $ldap
  * @param resource $result
  */
-function ldap_count_entries($link, $result): int {}
+function ldap_count_entries($ldap, $result): int {}
 
 /**
- * @param resource $link
+ * @param resource $ldap
  * @param resource $result
  * @return resource|false
  */
-function ldap_first_entry($link, $result) {}
+function ldap_first_entry($ldap, $result) {}
 
 /**
- * @param resource $link
+ * @param resource $ldap
  * @param resource $result
  * @return resource|false
  */
-function ldap_next_entry($link, $result) {}
+function ldap_next_entry($ldap, $result) {}
 
 /**
- * @param resource $link
+ * @param resource $ldap
  * @param resource $result
  */
-function ldap_get_entries($link, $result): array|false {}
+function ldap_get_entries($ldap, $result): array|false {}
 
 /**
- * @param resource $link
+ * @param resource $ldap
  * @param resource $entry
  */
-function ldap_first_attribute($link, $entry): string|false {}
+function ldap_first_attribute($ldap, $entry): string|false {}
 
 /**
- * @param resource $link
+ * @param resource $ldap
  * @param resource $entry
  */
-function ldap_next_attribute($link, $entry): string|false {}
+function ldap_next_attribute($ldap, $entry): string|false {}
 
 /**
- * @param resource $link
+ * @param resource $ldap
  * @param resource $entry
  */
-function ldap_get_attributes($link, $entry): array {}
+function ldap_get_attributes($ldap, $entry): array {}
 
 /**
- * @param resource $link
+ * @param resource $ldap
  * @param resource $entry
  */
-function ldap_get_values_len($link, $entry, string $attribute): array|false {}
+function ldap_get_values_len($ldap, $entry, string $attribute): array|false {}
 
 /**
- * @param resource $link
+ * @param resource $ldap
  * @param resource $entry
  * @alias ldap_get_values_len
  */
-function ldap_get_values($link, $entry, string $attribute): array|false {}
+function ldap_get_values($ldap, $entry, string $attribute): array|false {}
 
 /**
- * @param resource $link
+ * @param resource $ldap
  * @param resource $entry
  */
-function ldap_get_dn($link, $entry): string|false {}
+function ldap_get_dn($ldap, $entry): string|false {}
 
 function ldap_explode_dn(string $dn, int $with_attrib): array|false {}
 
 function ldap_dn2ufn(string $dn): string|false {}
 
-/** @param resource $link */
-function ldap_add($link, string $dn, array $entry, array $controls = []): bool {}
+/** @param resource $ldap */
+function ldap_add($ldap, string $dn, array $entry, array $controls = []): bool {}
 
 /**
- * @param resource $link
+ * @param resource $ldap
  * @return resource|false
  */
-function ldap_add_ext($link, string $dn, array $entry, array $controls = []) {}
+function ldap_add_ext($ldap, string $dn, array $entry, array $controls = []) {}
 
-/** @param resource $link */
-function ldap_delete($link, string $dn, array $controls = []): bool {}
+/** @param resource $ldap */
+function ldap_delete($ldap, string $dn, array $controls = []): bool {}
 
 /**
- * @param resource $link
+ * @param resource $ldap
  * @return resource|false
  */
-function ldap_delete_ext($link, string $dn, array $controls = []) {}
+function ldap_delete_ext($ldap, string $dn, array $controls = []) {}
 
-/** @param resource $link */
-function ldap_modify_batch($link, string $dn, array $modifications_info, array $controls = []): bool {}
+/** @param resource $ldap */
+function ldap_modify_batch($ldap, string $dn, array $modifications_info, array $controls = []): bool {}
 
-/** @param resource $link */
-function ldap_mod_add($link, string $dn, array $entry, array $controls = []): bool {}
+/** @param resource $ldap */
+function ldap_mod_add($ldap, string $dn, array $entry, array $controls = []): bool {}
 
 /**
- * @param resource $link
+ * @param resource $ldap
  * @return resource|false
  */
-function ldap_mod_add_ext($link, string $dn, array $entry, array $controls = []) {}
+function ldap_mod_add_ext($ldap, string $dn, array $entry, array $controls = []) {}
 
-/** @param resource $link */
-function ldap_mod_replace($link, string $dn, array $entry, array $controls = []): bool {}
+/** @param resource $ldap */
+function ldap_mod_replace($ldap, string $dn, array $entry, array $controls = []): bool {}
 
 /**
- * @param resource $link
+ * @param resource $ldap
  * @alias ldap_mod_replace
  */
-function ldap_modify($link, string $dn, array $entry, array $controls = []): bool {}
+function ldap_modify($ldap, string $dn, array $entry, array $controls = []): bool {}
 
 /**
- * @param resource $link
+ * @param resource $ldap
  * @return resource|false
  */
-function ldap_mod_replace_ext($link, string $dn, array $entry, array $controls = []) {}
+function ldap_mod_replace_ext($ldap, string $dn, array $entry, array $controls = []) {}
 
-/** @param resource $link */
-function ldap_mod_del($link, string $dn, array $entry, array $controls = []): bool {}
+/** @param resource $ldap */
+function ldap_mod_del($ldap, string $dn, array $entry, array $controls = []): bool {}
 
 /**
- * @param resource $link
+ * @param resource $ldap
  * @return resource|false
  */
-function ldap_mod_del_ext($link, string $dn, array $entry, array $controls = []) {}
+function ldap_mod_del_ext($ldap, string $dn, array $entry, array $controls = []) {}
 
-/** @param resource $link */
-function ldap_errno($link): int {}
+/** @param resource $ldap */
+function ldap_errno($ldap): int {}
 
-/** @param resource $link */
-function ldap_error($link): string {}
+/** @param resource $ldap */
+function ldap_error($ldap): string {}
 
 function ldap_err2str(int $errno): string {}
 
-/** @param resource $link */
-function ldap_compare($link, string $dn, string $attribute, string $value, array $controls = []): bool|int {}
+/** @param resource $ldap */
+function ldap_compare($ldap, string $dn, string $attribute, string $value, array $controls = []): bool|int {}
 
 
 #ifdef LDAP_CONTROL_PAGEDRESULTS
 /**
- * @param resource $link
+ * @param resource $ldap
  * @deprecated since 7.4
  */
-function ldap_control_paged_result($link, int $pagesize, bool $iscritical = false, string $cookie = ""): bool {}
+function ldap_control_paged_result($ldap, int $pagesize, bool $iscritical = false, string $cookie = ""): bool {}
 
 /**
- * @param resource $link
+ * @param resource $ldap
  * @param resource $result
  * @param string $cookie
  * @param int $estimated
  * @deprecated since 7.4
  */
-function ldap_control_paged_result_response($link, $result, &$cookie = null, &$estimated = null): bool {}
+function ldap_control_paged_result_response($ldap, $result, &$cookie = null, &$estimated = null): bool {}
 #endif
 
 #if (LDAP_API_VERSION > 2000) || defined(HAVE_ORALDAP)
-/** @param resource $link */
-function ldap_rename($link, string $dn, string $new_rdn, string $new_parent, bool $delete_old_rdn, array $controls = []): bool {}
+/** @param resource $ldap */
+function ldap_rename($ldap, string $dn, string $new_rdn, string $new_parent, bool $delete_old_rdn, array $controls = []): bool {}
 
 /**
- * @param resource $link
+ * @param resource $ldap
  * @return resource|false
  */
-function ldap_rename_ext($link, string $dn, string $newrdn, string $newparent, bool $deleteoldrdn, array $controls = []) {}
+function ldap_rename_ext($ldap, string $dn, string $newrdn, string $newparent, bool $deleteoldrdn, array $controls = []) {}
 
 
 /**
- * @param resource $link
+ * @param resource $ldap
  * @param array|string|int $retval
  */
-function ldap_get_option($link, int $option, &$retval = null): bool {}
+function ldap_get_option($ldap, int $option, &$retval = null): bool {}
 
 /**
- * @param resource|null $link
- * @param array|string|int|bool $newval
+ * @param resource|null $ldap
+ * @param array|string|int|bool $value
  */
-function ldap_set_option($link, int $option, $value): bool {}
+function ldap_set_option($ldap, int $option, $value): bool {}
 
 /**
- * @param resource $link
+ * @param resource $ldap
  * @param resource $result
  */
-function ldap_count_references($link, $result): int {}
+function ldap_count_references($ldap, $result): int {}
 
 /**
- * @param resource $link
+ * @param resource $ldap
  * @param resource $result
  * @return resource|false
  */
-function ldap_first_reference($link, $result) {}
+function ldap_first_reference($ldap, $result) {}
 
 /**
- * @param resource $link
+ * @param resource $ldap
  * @param resource $entry
  * @return resource|false
  */
-function ldap_next_reference($link, $entry) {}
+function ldap_next_reference($ldap, $entry) {}
 
 #ifdef HAVE_LDAP_PARSE_REFERENCE
 /**
- * @param resource $link
+ * @param resource $ldap
  * @param resource $entry
  * @param array $referrals
  */
-function ldap_parse_reference($link, $entry, &$referrals): bool {}
+function ldap_parse_reference($ldap, $entry, &$referrals): bool {}
 #endif
 
 #ifdef HAVE_LDAP_PARSE_RESULT
 /**
- * @param resource $link
+ * @param resource $ldap
  * @param resource $result
  * @param int $errcode
  * @param string $matcheddn
@@ -267,18 +267,18 @@ function ldap_parse_reference($link, $entry, &$referrals): bool {}
  * @param array $referrals
  * @param array $controls
  */
-function ldap_parse_result($link, $result, &$errcode, &$matcheddn = null, &$errmsg = null, &$referrals = null, &$controls = null): bool {}
+function ldap_parse_result($ldap, $result, &$errcode, &$matcheddn = null, &$errmsg = null, &$referrals = null, &$controls = null): bool {}
 #endif
 #endif
 
 #if defined(LDAP_API_FEATURE_X_OPENLDAP) && defined(HAVE_3ARG_SETREBINDPROC)
-/** @param resource $link */
-function ldap_set_rebind_proc($link, ?callable $callback): bool {}
+/** @param resource $ldap */
+function ldap_set_rebind_proc($ldap, ?callable $callback): bool {}
 #endif
 
 #ifdef HAVE_LDAP_START_TLS_S
-/** @param resource $link */
-function ldap_start_tls($link): bool {}
+/** @param resource $ldap */
+function ldap_start_tls($ldap): bool {}
 #endif
 
 function ldap_escape(string $value, string $ignore = "", int $flags = 0): string {}
@@ -292,39 +292,39 @@ function ldap_8859_to_t61(string $value): string|false {}
 
 #ifdef HAVE_LDAP_EXTENDED_OPERATION_S
 /**
- * @param resource $link
+ * @param resource $ldap
  * @param string $retdata
  * @param string $retoid
  * @return resource|bool
  */
-function ldap_exop($link, string $reqoid, ?string $reqdata = null, ?array $controls = [], &$retdata = null, &$retoid = null) {}
+function ldap_exop($ldap, string $reqoid, ?string $reqdata = null, ?array $controls = [], &$retdata = null, &$retoid = null) {}
 #endif
 
 #ifdef HAVE_LDAP_PASSWD
 /**
- * @param resource $link
+ * @param resource $ldap
  * @param array $controls
  */
-function ldap_exop_passwd($link, string $user = "", string $old_password = "", string $new_password = "", &$controls = null): string|bool {}
+function ldap_exop_passwd($ldap, string $user = "", string $old_password = "", string $new_password = "", &$controls = null): string|bool {}
 #endif
 
 
 #ifdef HAVE_LDAP_WHOAMI_S
-/** @param resource $link */
-function ldap_exop_whoami($link): string|bool {}
+/** @param resource $ldap */
+function ldap_exop_whoami($ldap): string|bool {}
 #endif
 
 #ifdef HAVE_LDAP_REFRESH_S
-/** @param resource $link */
-function ldap_exop_refresh($link, string $dn, int $ttl): int|false {}
+/** @param resource $ldap */
+function ldap_exop_refresh($ldap, string $dn, int $ttl): int|false {}
 #endif
 
 #ifdef HAVE_LDAP_PARSE_EXTENDED_RESULT
 /**
- * @param resource $link
+ * @param resource $ldap
  * @param resource $result
  * @param string $retdata
  * @param string $retoid
  */
-function ldap_parse_exop($link, $result, &$retdata = null, &$retoid = null): bool {}
+function ldap_parse_exop($ldap, $result, &$retdata = null, &$retoid = null): bool {}
 #endif
diff --git a/ext/ldap/ldap_arginfo.h b/ext/ldap/ldap_arginfo.h
index 25f8227911..24fe4c3acd 100644
--- a/ext/ldap/ldap_arginfo.h
+++ b/ext/ldap/ldap_arginfo.h
@@ -1,13 +1,13 @@
 /* This is a generated file, edit the .stub.php file instead.
- * Stub hash: 739893b4bf6f34da80b7c7b10a670c16d4239bdb */
+ * Stub hash: 4802f25ebc9936ccd6e4705d07a49a61892b71f3 */
 
 #if defined(HAVE_ORALDAP)
 ZEND_BEGIN_ARG_INFO_EX(arginfo_ldap_connect, 0, 0, 0)
 	ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, uri, IS_STRING, 1, "null")
 	ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, port, IS_LONG, 0, "389")
 	ZEND_ARG_TYPE_INFO(0, wallet, IS_STRING, 0)
-	ZEND_ARG_TYPE_INFO(0, wallet_passwd, IS_STRING, 0)
-	ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, authmode, IS_LONG, 0, "GSLC_SSL_NO_AUTH")
+	ZEND_ARG_TYPE_INFO(0, password, IS_STRING, 0)
+	ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, auth_mode, IS_LONG, 0, "GSLC_SSL_NO_AUTH")
 ZEND_END_ARG_INFO()
 #endif
 
@@ -19,19 +19,19 @@ ZEND_END_ARG_INFO()
 #endif
 
 ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_ldap_unbind, 0, 1, _IS_BOOL, 0)
-	ZEND_ARG_INFO(0, link)
+	ZEND_ARG_INFO(0, ldap)
 ZEND_END_ARG_INFO()
 
 #define arginfo_ldap_close arginfo_ldap_unbind
 
 ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_ldap_bind, 0, 1, _IS_BOOL, 0)
-	ZEND_ARG_INFO(0, link)
+	ZEND_ARG_INFO(0, ldap)
 	ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, dn, IS_STRING, 1, "null")
 	ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, password, IS_STRING, 1, "null")
 ZEND_END_ARG_INFO()
 
 ZEND_BEGIN_ARG_INFO_EX(arginfo_ldap_bind_ext, 0, 0, 1)
-	ZEND_ARG_INFO(0, link)
+	ZEND_ARG_INFO(0, ldap)
 	ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, dn, IS_STRING, 1, "null")
 	ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, password, IS_STRING, 1, "null")
 	ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, controls, IS_ARRAY, 0, "[]")
@@ -39,7 +39,7 @@ ZEND_END_ARG_INFO()
 
 #if defined(HAVE_LDAP_SASL)
 ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_ldap_sasl_bind, 0, 1, _IS_BOOL, 0)
-	ZEND_ARG_INFO(0, link)
+	ZEND_ARG_INFO(0, ldap)
 	ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, dn, IS_STRING, 1, "null")
 	ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, password, IS_STRING, 1, "null")
 	ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, mech, IS_STRING, 1, "null")
@@ -51,7 +51,7 @@ ZEND_END_ARG_INFO()
 #endif
 
 ZEND_BEGIN_ARG_INFO_EX(arginfo_ldap_read, 0, 0, 3)
-	ZEND_ARG_INFO(0, link)
+	ZEND_ARG_INFO(0, ldap)
 	ZEND_ARG_TYPE_MASK(0, base, MAY_BE_ARRAY|MAY_BE_STRING, NULL)
 	ZEND_ARG_TYPE_MASK(0, filter, MAY_BE_ARRAY|MAY_BE_STRING, NULL)
 	ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, attributes, IS_ARRAY, 0, "[]")
@@ -69,36 +69,36 @@ ZEND_END_ARG_INFO()
 #define arginfo_ldap_free_result arginfo_ldap_unbind
 
 ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_ldap_count_entries, 0, 2, IS_LONG, 0)
-	ZEND_ARG_INFO(0, link)
+	ZEND_ARG_INFO(0, ldap)
 	ZEND_ARG_INFO(0, result)
 ZEND_END_ARG_INFO()
 
 ZEND_BEGIN_ARG_INFO_EX(arginfo_ldap_first_entry, 0, 0, 2)
-	ZEND_ARG_INFO(0, link)
+	ZEND_ARG_INFO(0, ldap)
 	ZEND_ARG_INFO(0, result)
 ZEND_END_ARG_INFO()
 
 #define arginfo_ldap_next_entry arginfo_ldap_first_entry
 
 ZEND_BEGIN_ARG_WITH_RETURN_TYPE_MASK_EX(arginfo_ldap_get_entries, 0, 2, MAY_BE_ARRAY|MAY_BE_FALSE)
-	ZEND_ARG_INFO(0, link)
+	ZEND_ARG_INFO(0, ldap)
 	ZEND_ARG_INFO(0, result)
 ZEND_END_ARG_INFO()
 
 ZEND_BEGIN_ARG_WITH_RETURN_TYPE_MASK_EX(arginfo_ldap_first_attribute, 0, 2, MAY_BE_STRING|MAY_BE_FALSE)
-	ZEND_ARG_INFO(0, link)
+	ZEND_ARG_INFO(0, ldap)
 	ZEND_ARG_INFO(0, entry)
 ZEND_END_ARG_INFO()
 
 #define arginfo_ldap_next_attribute arginfo_ldap_first_attribute
 
 ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_ldap_get_attributes, 0, 2, IS_ARRAY, 0)
-	ZEND_ARG_INFO(0, link)
+	ZEND_ARG_INFO(0, ldap)
 	ZEND_ARG_INFO(0, entry)
 ZEND_END_ARG_INFO()
 
 ZEND_BEGIN_ARG_WITH_RETURN_TYPE_MASK_EX(arginfo_ldap_get_values_len, 0, 3, MAY_BE_ARRAY|MAY_BE_FALSE)
-	ZEND_ARG_INFO(0, link)
+	ZEND_ARG_INFO(0, ldap)
 	ZEND_ARG_INFO(0, entry)
 	ZEND_ARG_TYPE_INFO(0, attribute, IS_STRING, 0)
 ZEND_END_ARG_INFO()
@@ -117,33 +117,33 @@ ZEND_BEGIN_ARG_WITH_RETURN_TYPE_MASK_EX(arginfo_ldap_dn2ufn, 0, 1, MAY_BE_STRING
 ZEND_END_ARG_INFO()
 
 ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_ldap_add, 0, 3, _IS_BOOL, 0)
-	ZEND_ARG_INFO(0, link)
+	ZEND_ARG_INFO(0, ldap)
 	ZEND_ARG_TYPE_INFO(0, dn, IS_STRING, 0)
 	ZEND_ARG_TYPE_INFO(0, entry, IS_ARRAY, 0)
 	ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, controls, IS_ARRAY, 0, "[]")
 ZEND_END_ARG_INFO()
 
 ZEND_BEGIN_ARG_INFO_EX(arginfo_ldap_add_ext, 0, 0, 3)
-	ZEND_ARG_INFO(0, link)
+	ZEND_ARG_INFO(0, ldap)
 	ZEND_ARG_TYPE_INFO(0, dn, IS_STRING, 0)
 	ZEND_ARG_TYPE_INFO(0, entry, IS_ARRAY, 0)
 	ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, controls, IS_ARRAY, 0, "[]")
 ZEND_END_ARG_INFO()
 
 ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_ldap_delete, 0, 2, _IS_BOOL, 0)
-	ZEND_ARG_INFO(0, link)
+	ZEND_ARG_INFO(0, ldap)
 	ZEND_ARG_TYPE_INFO(0, dn, IS_STRING, 0)
 	ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, controls, IS_ARRAY, 0, "[]")
 ZEND_END_ARG_INFO()
 
 ZEND_BEGIN_ARG_INFO_EX(arginfo_ldap_delete_ext, 0, 0, 2)
-	ZEND_ARG_INFO(0, link)
+	ZEND_ARG_INFO(0, ldap)
 	ZEND_ARG_TYPE_INFO(0, dn, IS_STRING, 0)
 	ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, controls, IS_ARRAY, 0, "[]")
 ZEND_END_ARG_INFO()
 
 ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_ldap_modify_batch, 0, 3, _IS_BOOL, 0)
-	ZEND_ARG_INFO(0, link)
+	ZEND_ARG_INFO(0, ldap)
 	ZEND_ARG_TYPE_INFO(0, dn, IS_STRING, 0)
 	ZEND_ARG_TYPE_INFO(0, modifications_info, IS_ARRAY, 0)
 	ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, controls, IS_ARRAY, 0, "[]")
@@ -164,11 +164,11 @@ ZEND_END_ARG_INFO()
 #define arginfo_ldap_mod_del_ext arginfo_ldap_add_ext
 
 ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_ldap_errno, 0, 1, IS_LONG, 0)
-	ZEND_ARG_INFO(0, link)
+	ZEND_ARG_INFO(0, ldap)
 ZEND_END_ARG_INFO()
 
 ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_ldap_error, 0, 1, IS_STRING, 0)
-	ZEND_ARG_INFO(0, link)
+	ZEND_ARG_INFO(0, ldap)
 ZEND_END_ARG_INFO()
 
 ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_ldap_err2str, 0, 1, IS_STRING, 0)
@@ -176,7 +176,7 @@ ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_ldap_err2str, 0, 1, IS_STRING, 0
 ZEND_END_ARG_INFO()
 
 ZEND_BEGIN_ARG_WITH_RETURN_TYPE_MASK_EX(arginfo_ldap_compare, 0, 4, MAY_BE_BOOL|MAY_BE_LONG)
-	ZEND_ARG_INFO(0, link)
+	ZEND_ARG_INFO(0, ldap)
 	ZEND_ARG_TYPE_INFO(0, dn, IS_STRING, 0)
 	ZEND_ARG_TYPE_INFO(0, attribute, IS_STRING, 0)
 	ZEND_ARG_TYPE_INFO(0, value, IS_STRING, 0)
@@ -185,7 +185,7 @@ ZEND_END_ARG_INFO()
 
 #if defined(LDAP_CONTROL_PAGEDRESULTS)
 ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_ldap_control_paged_result, 0, 2, _IS_BOOL, 0)
-	ZEND_ARG_INFO(0, link)
+	ZEND_ARG_INFO(0, ldap)
 	ZEND_ARG_TYPE_INFO(0, pagesize, IS_LONG, 0)
 	ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, iscritical, _IS_BOOL, 0, "false")
 	ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, cookie, IS_STRING, 0, "\"\"")
@@ -194,7 +194,7 @@ ZEND_END_ARG_INFO()
 
 #if defined(LDAP_CONTROL_PAGEDRESULTS)
 ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_ldap_control_paged_result_response, 0, 2, _IS_BOOL, 0)
-	ZEND_ARG_INFO(0, link)
+	ZEND_ARG_INFO(0, ldap)
 	ZEND_ARG_INFO(0, result)
 	ZEND_ARG_INFO_WITH_DEFAULT_VALUE(1, cookie, "null")
 	ZEND_ARG_INFO_WITH_DEFAULT_VALUE(1, estimated, "null")
@@ -203,18 +203,18 @@ ZEND_END_ARG_INFO()
 
 #if (LDAP_API_VERSION > 2000) || defined(HAVE_ORALDAP)
 ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_ldap_rename, 0, 5, _IS_BOOL, 0)
-	ZEND_ARG_INFO(0, link)
+	ZEND_ARG_INFO(0, ldap)
 	ZEND_ARG_TYPE_INFO(0, dn, IS_STRING, 0)
-	ZEND_ARG_TYPE_INFO(0, newrdn, IS_STRING, 0)
-	ZEND_ARG_TYPE_INFO(0, newparent, IS_STRING, 0)
-	ZEND_ARG_TYPE_INFO(0, deleteoldrdn, _IS_BOOL, 0)
+	ZEND_ARG_TYPE_INFO(0, new_rdn, IS_STRING, 0)
+	ZEND_ARG_TYPE_INFO(0, new_parent, IS_STRING, 0)
+	ZEND_ARG_TYPE_INFO(0, delete_old_rdn, _IS_BOOL, 0)
 	ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, controls, IS_ARRAY, 0, "[]")
 ZEND_END_ARG_INFO()
 #endif
 
 #if (LDAP_API_VERSION > 2000) || defined(HAVE_ORALDAP)
 ZEND_BEGIN_ARG_INFO_EX(arginfo_ldap_rename_ext, 0, 0, 5)
-	ZEND_ARG_INFO(0, link)
+	ZEND_ARG_INFO(0, ldap)
 	ZEND_ARG_TYPE_INFO(0, dn, IS_STRING, 0)
 	ZEND_ARG_TYPE_INFO(0, newrdn, IS_STRING, 0)
 	ZEND_ARG_TYPE_INFO(0, newparent, IS_STRING, 0)
@@ -225,7 +225,7 @@ ZEND_END_ARG_INFO()
 
 #if (LDAP_API_VERSION > 2000) || defined(HAVE_ORALDAP)
 ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_ldap_get_option, 0, 2, _IS_BOOL, 0)
-	ZEND_ARG_INFO(0, link)
+	ZEND_ARG_INFO(0, ldap)
 	ZEND_ARG_TYPE_INFO(0, option, IS_LONG, 0)
 	ZEND_ARG_INFO_WITH_DEFAULT_VALUE(1, retval, "null")
 ZEND_END_ARG_INFO()
@@ -233,36 +233,36 @@ ZEND_END_ARG_INFO()
 
 #if (LDAP_API_VERSION > 2000) || defined(HAVE_ORALDAP)
 ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_ldap_set_option, 0, 3, _IS_BOOL, 0)
-	ZEND_ARG_INFO(0, link)
+	ZEND_ARG_INFO(0, ldap)
 	ZEND_ARG_TYPE_INFO(0, option, IS_LONG, 0)
-	ZEND_ARG_INFO(0, newval)
+	ZEND_ARG_INFO(0, value)
 ZEND_END_ARG_INFO()
 #endif
 
 #if (LDAP_API_VERSION > 2000) || defined(HAVE_ORALDAP)
 ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_ldap_count_references, 0, 2, IS_LONG, 0)
-	ZEND_ARG_INFO(0, link)
+	ZEND_ARG_INFO(0, ldap)
 	ZEND_ARG_INFO(0, result)
 ZEND_END_ARG_INFO()
 #endif
 
 #if (LDAP_API_VERSION > 2000) || defined(HAVE_ORALDAP)
 ZEND_BEGIN_ARG_INFO_EX(arginfo_ldap_first_reference, 0, 0, 2)
-	ZEND_ARG_INFO(0, link)
+	ZEND_ARG_INFO(0, ldap)
 	ZEND_ARG_INFO(0, result)
 ZEND_END_ARG_INFO()
 #endif
 
 #if (LDAP_API_VERSION > 2000) || defined(HAVE_ORALDAP)
 ZEND_BEGIN_ARG_INFO_EX(arginfo_ldap_next_reference, 0, 0, 2)
-	ZEND_ARG_INFO(0, link)
+	ZEND_ARG_INFO(0, ldap)
 	ZEND_ARG_INFO(0, entry)
 ZEND_END_ARG_INFO()
 #endif
 
 #if (LDAP_API_VERSION > 2000) || defined(HAVE_ORALDAP) && defined(HAVE_LDAP_PARSE_REFERENCE)
 ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_ldap_parse_reference, 0, 3, _IS_BOOL, 0)
-	ZEND_ARG_INFO(0, link)
+	ZEND_ARG_INFO(0, ldap)
 	ZEND_ARG_INFO(0, entry)
 	ZEND_ARG_INFO(1, referrals)
 ZEND_END_ARG_INFO()
@@ -270,7 +270,7 @@ ZEND_END_ARG_INFO()
 
 #if (LDAP_API_VERSION > 2000) || defined(HAVE_ORALDAP) && defined(HAVE_LDAP_PARSE_RESULT)
 ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_ldap_parse_result, 0, 3, _IS_BOOL, 0)
-	ZEND_ARG_INFO(0, link)
+	ZEND_ARG_INFO(0, ldap)
 	ZEND_ARG_INFO(0, result)
 	ZEND_ARG_INFO(1, errcode)
 	ZEND_ARG_INFO_WITH_DEFAULT_VALUE(1, matcheddn, "null")
@@ -282,14 +282,14 @@ ZEND_END_ARG_INFO()
 
 #if defined(LDAP_API_FEATURE_X_OPENLDAP) && defined(HAVE_3ARG_SETREBINDPROC)
 ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_ldap_set_rebind_proc, 0, 2, _IS_BOOL, 0)
-	ZEND_ARG_INFO(0, link)
+	ZEND_ARG_INFO(0, ldap)
 	ZEND_ARG_TYPE_INFO(0, callback, IS_CALLABLE, 1)
 ZEND_END_ARG_INFO()
 #endif
 
 #if defined(HAVE_LDAP_START_TLS_S)
 ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_ldap_start_tls, 0, 1, _IS_BOOL, 0)
-	ZEND_ARG_INFO(0, link)
+	ZEND_ARG_INFO(0, ldap)
 ZEND_END_ARG_INFO()
 #endif
 
@@ -311,7 +311,7 @@ ZEND_END_ARG_INFO()
 
 #if defined(HAVE_LDAP_EXTENDED_OPERATION_S)
 ZEND_BEGIN_ARG_INFO_EX(arginfo_ldap_exop, 0, 0, 2)
-	ZEND_ARG_INFO(0, link)
+	ZEND_ARG_INFO(0, ldap)
 	ZEND_ARG_TYPE_INFO(0, reqoid, IS_STRING, 0)
 	ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, reqdata, IS_STRING, 1, "null")
 	ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, controls, IS_ARRAY, 1, "[]")
@@ -322,23 +322,23 @@ ZEND_END_ARG_INFO()
 
 #if defined(HAVE_LDAP_PASSWD)
 ZEND_BEGIN_ARG_WITH_RETURN_TYPE_MASK_EX(arginfo_ldap_exop_passwd, 0, 1, MAY_BE_STRING|MAY_BE_BOOL)
-	ZEND_ARG_INFO(0, link)
+	ZEND_ARG_INFO(0, ldap)
 	ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, user, IS_STRING, 0, "\"\"")
-	ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, oldpw, IS_STRING, 0, "\"\"")
-	ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, newpw, IS_STRING, 0, "\"\"")
+	ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, old_password, IS_STRING, 0, "\"\"")
+	ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, new_password, IS_STRING, 0, "\"\"")
 	ZEND_ARG_INFO_WITH_DEFAULT_VALUE(1, controls, "null")
 ZEND_END_ARG_INFO()
 #endif
 
 #if defined(HAVE_LDAP_WHOAMI_S)
 ZEND_BEGIN_ARG_WITH_RETURN_TYPE_MASK_EX(arginfo_ldap_exop_whoami, 0, 1, MAY_BE_STRING|MAY_BE_BOOL)
-	ZEND_ARG_INFO(0, link)
+	ZEND_ARG_INFO(0, ldap)
 ZEND_END_ARG_INFO()
 #endif
 
 #if defined(HAVE_LDAP_REFRESH_S)
 ZEND_BEGIN_ARG_WITH_RETURN_TYPE_MASK_EX(arginfo_ldap_exop_refresh, 0, 3, MAY_BE_LONG|MAY_BE_FALSE)
-	ZEND_ARG_INFO(0, link)
+	ZEND_ARG_INFO(0, ldap)
 	ZEND_ARG_TYPE_INFO(0, dn, IS_STRING, 0)
 	ZEND_ARG_TYPE_INFO(0, ttl, IS_LONG, 0)
 ZEND_END_ARG_INFO()
@@ -346,7 +346,7 @@ ZEND_END_ARG_INFO()
 
 #if defined(HAVE_LDAP_PARSE_EXTENDED_RESULT)
 ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_ldap_parse_exop, 0, 2, _IS_BOOL, 0)
-	ZEND_ARG_INFO(0, link)
+	ZEND_ARG_INFO(0, ldap)
 	ZEND_ARG_INFO(0, result)
 	ZEND_ARG_INFO_WITH_DEFAULT_VALUE(1, retdata, "null")
 	ZEND_ARG_INFO_WITH_DEFAULT_VALUE(1, retoid, "null")
diff --git a/ext/ldap/tests/ldap_search_error.phpt b/ext/ldap/tests/ldap_search_error.phpt
index 2eec205ef5..7041c66746 100644
--- a/ext/ldap/tests/ldap_search_error.phpt
+++ b/ext/ldap/tests/ldap_search_error.phpt
@@ -46,6 +46,6 @@ bool(false)
 
 Warning: ldap_search(): Array initialization wrong in %s on line %d
 bool(false)
-ldap_search(): Argument #1 ($link) cannot be empty
+ldap_search(): Argument #1 ($ldap) cannot be empty
 ldap_search(): Argument #2 ($base) must have the same number of elements as the links array
 ldap_search(): Argument #3 ($filter) must have the same number of elements as the links array
diff --git a/ext/ldap/tests/ldap_set_option_error.phpt b/ext/ldap/tests/ldap_set_option_error.phpt
index f97193e22b..fba37df6ef 100644
--- a/ext/ldap/tests/ldap_set_option_error.phpt
+++ b/ext/ldap/tests/ldap_set_option_error.phpt
@@ -38,6 +38,6 @@ var_dump(ldap_set_option($link, 999999, 999999));
 --EXPECT--
 bool(false)
 ValueError: ldap_set_option(): Control must have an "oid" key
-TypeError: ldap_set_option(): Argument #3 ($newval) must contain only arrays, where each array is a control
-TypeError: ldap_set_option(): Argument #3 ($newval) must be of type array for the LDAP_OPT_CLIENT_CONTROLS option, string given
+TypeError: ldap_set_option(): Argument #3 ($value) must contain only arrays, where each array is a control
+TypeError: ldap_set_option(): Argument #3 ($value) must be of type array for the LDAP_OPT_CLIENT_CONTROLS option, string given
 bool(false)