From: Azat Khuzhin <azat@libevent.org>
Date: Sun, 24 May 2020 23:35:55 +0000 (+0300)
Subject: evdns: bufferevent_setcb before bufferevent_free is redundant
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=1cf24f04ff94c8864dca7ca61e3ff2c2537c97bb;p=libevent

evdns: bufferevent_setcb before bufferevent_free is redundant
---

diff --git a/evdns.c b/evdns.c
index c30c5188..75bbbb38 100644
--- a/evdns.c
+++ b/evdns.c
@@ -531,7 +531,6 @@ evdns_tcp_disconnect(struct tcp_connection *conn)
 	conn->state = TS_DISCONNECTED;
 	conn->awaiting_packet_size = 0;
 	if (conn->bev) {
-		bufferevent_setcb(conn->bev, NULL, NULL, NULL, NULL);
 		bufferevent_free(conn->bev);
 		conn->bev = NULL;
 	}
@@ -2137,10 +2136,8 @@ incoming_conn_cb(struct evconnlistener *listener, evutil_socket_t fd,
 
 	return;
 error:
-	if (bev) {
-		bufferevent_setcb(bev, NULL, NULL, NULL, NULL);
+	if (bev)
 		bufferevent_free(bev);
-	}
 	return;
 }