From: Todd C. Miller Date: Fri, 14 Nov 2014 21:56:29 +0000 (-0700) Subject: Fix typo in hook return value check. X-Git-Tag: SUDO_1_8_12^2~78 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=1c96c5ec396da7c4692c223ff0336c1866b4da15;p=sudo Fix typo in hook return value check. --- diff --git a/src/hooks.c b/src/hooks.c index 1d3a3bcb4..3f376d455 100644 --- a/src/hooks.c +++ b/src/hooks.c @@ -74,7 +74,7 @@ process_hooks_setenv(const char *name, const char *value, int overwrite) /* First process the hooks. */ SLIST_FOREACH(hook, &sudo_hook_setenv_list, entries) { rc = hook->u.setenv_fn(name, value, overwrite, hook->closure); - if (rc == SUDO_HOOK_RET_STOP || SUDO_HOOK_RET_ERROR) + if (rc == SUDO_HOOK_RET_STOP || rc == SUDO_HOOK_RET_ERROR) break; } return rc; @@ -90,7 +90,7 @@ process_hooks_putenv(char *string) /* First process the hooks. */ SLIST_FOREACH(hook, &sudo_hook_putenv_list, entries) { rc = hook->u.putenv_fn(string, hook->closure); - if (rc == SUDO_HOOK_RET_STOP || SUDO_HOOK_RET_ERROR) + if (rc == SUDO_HOOK_RET_STOP || rc == SUDO_HOOK_RET_ERROR) break; } return rc; @@ -107,7 +107,7 @@ process_hooks_getenv(const char *name, char **value) /* First process the hooks. */ SLIST_FOREACH(hook, &sudo_hook_getenv_list, entries) { rc = hook->u.getenv_fn(name, &val, hook->closure); - if (rc == SUDO_HOOK_RET_STOP || SUDO_HOOK_RET_ERROR) + if (rc == SUDO_HOOK_RET_STOP || rc == SUDO_HOOK_RET_ERROR) break; } if (val != NULL) @@ -125,7 +125,7 @@ process_hooks_unsetenv(const char *name) /* First process the hooks. */ SLIST_FOREACH(hook, &sudo_hook_unsetenv_list, entries) { rc = hook->u.unsetenv_fn(name, hook->closure); - if (rc == SUDO_HOOK_RET_STOP || SUDO_HOOK_RET_ERROR) + if (rc == SUDO_HOOK_RET_STOP || rc == SUDO_HOOK_RET_ERROR) break; } return rc;