From: Matthew Fernandez <matthew.fernandez@gmail.com>
Date: Sat, 26 Feb 2022 19:00:08 +0000 (-0800)
Subject: expr: [nfc] remove unnecessary parens in 'eval(…).string' expressions
X-Git-Tag: 4.0.0~204^2~6
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=1c52c57e803b3b3b89ccbd26bf7405e4089095ce;p=graphviz

expr: [nfc] remove unnecessary parens in 'eval(…).string' expressions
---

diff --git a/lib/expr/exeval.c b/lib/expr/exeval.c
index 535edab55..ac27d3820 100644
--- a/lib/expr/exeval.c
+++ b/lib/expr/exeval.c
@@ -861,9 +861,9 @@ exsplit(Expr_t * ex, Exnode_t * expr, void *env)
 	size_t sz;
 	Dt_t* arr = (Dt_t*)expr->data.split.array->local.pointer;
 
-	str = (eval(ex, expr->data.split.string, env)).string;
+	str = eval(ex, expr->data.split.string, env).string;
 	if (expr->data.split.seps)
-		seps = (eval(ex, expr->data.split.seps, env)).string;
+		seps = eval(ex, expr->data.split.seps, env).string;
 	else
 		seps = " \t\n";
 
@@ -916,9 +916,9 @@ extokens(Expr_t * ex, Exnode_t * expr, void *env)
 	size_t sz;
 	Dt_t* arr = (Dt_t*)expr->data.split.array->local.pointer;
 
-	str = (eval(ex, expr->data.split.string, env)).string;
+	str = eval(ex, expr->data.split.string, env).string;
 	if (expr->data.split.seps)
-		seps = (eval(ex, expr->data.split.seps, env)).string;
+		seps = eval(ex, expr->data.split.seps, env).string;
 	else
 		seps = " \t\n";
 
@@ -962,10 +962,10 @@ exsub(Expr_t * ex, Exnode_t * expr, void *env, bool global)
 	int flags = STR_MAXIMAL;
 	int ng;
 
-	str = (eval(ex, expr->data.string.base, env)).string;
-	pat = (eval(ex, expr->data.string.pat, env)).string;
+	str = eval(ex, expr->data.string.base, env).string;
+	pat = eval(ex, expr->data.string.pat, env).string;
 	if (expr->data.string.repl)
-		repl = (eval(ex, expr->data.string.repl, env)).string;
+		repl = eval(ex, expr->data.string.repl, env).string;
 	else
 		repl = 0;