From: Chandler Carruth <chandlerc@gmail.com>
Date: Tue, 20 Dec 2016 03:32:17 +0000 (+0000)
Subject: [PM] Rework a loop in the CGSCC update logic to be more conservative and
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=1c4b8129419698a189be6119cd9d7b971432ffb1;p=llvm

[PM] Rework a loop in the CGSCC update logic to be more conservative and
clear. The current RefSCC can occur in exactly one position so we should
just enforce that and leverage the property rather than checking for it
anywhere.

This addresses review comments made on another patch.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@290162 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Analysis/CGSCCPassManager.cpp b/lib/Analysis/CGSCCPassManager.cpp
index b2bee0258d1..5c1485d02de 100644
--- a/lib/Analysis/CGSCCPassManager.cpp
+++ b/lib/Analysis/CGSCCPassManager.cpp
@@ -329,13 +329,17 @@ LazyCallGraph::SCC &llvm::updateCGAndAnalysisManagerForFunctionPass(
       assert(G.lookupSCC(N) == C && "Changed the SCC when splitting RefSCCs!");
       RC = &C->getOuterRefSCC();
       assert(G.lookupRefSCC(N) == RC && "Failed to update current RefSCC!");
-      for (RefSCC *NewRC : reverse(NewRefSCCs))
-        if (NewRC != RC) {
-          UR.RCWorklist.insert(NewRC);
-          if (DebugLogging)
-            dbgs() << "Enqueuing a new RefSCC in the update worklist: "
-                   << *NewRC << "\n";
-        }
+      assert(NewRefSCCs.front() == RC &&
+             "New current RefSCC not first in the returned list!");
+      for (RefSCC *NewRC : reverse(
+               make_range(std::next(NewRefSCCs.begin()), NewRefSCCs.end()))) {
+        assert(NewRC != RC && "Should not encounter the current RefSCC further "
+                              "in the postorder list of new RefSCCs.");
+        UR.RCWorklist.insert(NewRC);
+        if (DebugLogging)
+          dbgs() << "Enqueuing a new RefSCC in the update worklist: " << *NewRC
+                 << "\n";
+      }
     }
   }