From: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Date: Tue, 11 Jun 2019 16:37:59 +0000 (-0700)
Subject: closes bpo-33758: Skip test_get_type_hints_modules_forwardref. (GH-13977)
X-Git-Tag: v3.8.0b2~169
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=1c31d19e35172c7de1beec5c48a5b632d16385d9;p=python

closes bpo-33758: Skip test_get_type_hints_modules_forwardref. (GH-13977)


This test "works" if things are run in the right order, so it's better to use @skip than @expectedFailure here.
(cherry picked from commit 910b3fcb01c29f18ffd53086e36cd2cb9e5fae55)

Co-authored-by: Benjamin Peterson <benjamin@python.org>
---

diff --git a/Lib/test/test_typing.py b/Lib/test/test_typing.py
index a65d639fe9..ba001c3462 100644
--- a/Lib/test/test_typing.py
+++ b/Lib/test/test_typing.py
@@ -3,7 +3,7 @@ import collections
 import pickle
 import re
 import sys
-from unittest import TestCase, main, skipUnless, SkipTest, expectedFailure
+from unittest import TestCase, main, skipUnless, SkipTest, skip
 from copy import copy, deepcopy
 
 from typing import Any, NoReturn
@@ -2654,7 +2654,7 @@ class GetTypeHintTests(BaseTestCase):
         self.assertEqual(gth(ann_module2), {})
         self.assertEqual(gth(ann_module3), {})
 
-    @expectedFailure
+    @skip("known bug")
     def test_get_type_hints_modules_forwardref(self):
         # FIXME: This currently exposes a bug in typing. Cached forward references
         # don't account for the case where there are multiple types of the same