From: Rafael Espindola Date: Mon, 3 Oct 2016 17:49:19 +0000 (+0000) Subject: Use getSize instead of data().size(). NFC. X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=1c287c05a69ab8c4a41123c53d2113b28e1e73c9;p=llvm Use getSize instead of data().size(). NFC. Also assert isFinalized in getSize(). This just reduces the noise from another patch. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@283125 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/include/llvm/MC/StringTableBuilder.h b/include/llvm/MC/StringTableBuilder.h index f2b8ecd2d99..c8908c384c8 100644 --- a/include/llvm/MC/StringTableBuilder.h +++ b/include/llvm/MC/StringTableBuilder.h @@ -61,7 +61,7 @@ public: return StringIndexMap; } - size_t getSize() const { return Size; } + size_t getSize() const; void clear(); private: diff --git a/lib/MC/MachObjectWriter.cpp b/lib/MC/MachObjectWriter.cpp index e39271949d9..acb79223d4e 100644 --- a/lib/MC/MachObjectWriter.cpp +++ b/lib/MC/MachObjectWriter.cpp @@ -882,7 +882,7 @@ void MachObjectWriter::writeObject(MCAssembler &Asm, sizeof(MachO::nlist_64) : sizeof(MachO::nlist)); writeSymtabLoadCommand(SymbolTableOffset, NumSymTabSymbols, - StringTableOffset, StringTable.data().size()); + StringTableOffset, StringTable.getSize()); writeDysymtabLoadCommand(FirstLocalSymbol, NumLocalSymbols, FirstExternalSymbol, NumExternalSymbols, diff --git a/lib/MC/StringTableBuilder.cpp b/lib/MC/StringTableBuilder.cpp index 9d95952a6d3..24ae9d034d2 100644 --- a/lib/MC/StringTableBuilder.cpp +++ b/lib/MC/StringTableBuilder.cpp @@ -34,6 +34,11 @@ StringTableBuilder::StringTableBuilder(Kind K, unsigned Alignment) } } +size_t StringTableBuilder::getSize() const { + assert(isFinalized()); + return Size; +} + typedef std::pair, size_t> StringPair; // Returns the character at Pos from end of a string. diff --git a/tools/yaml2obj/yaml2elf.cpp b/tools/yaml2obj/yaml2elf.cpp index c98093431a7..60d21599613 100644 --- a/tools/yaml2obj/yaml2elf.cpp +++ b/tools/yaml2obj/yaml2elf.cpp @@ -307,7 +307,7 @@ void ELFState::initStrtabSectionHeader(Elf_Shdr &SHeader, StringRef Name, SHeader.sh_type = ELF::SHT_STRTAB; CBA.getOSAndAlignedOffset(SHeader.sh_offset, SHeader.sh_addralign) << STB.data(); - SHeader.sh_size = STB.data().size(); + SHeader.sh_size = STB.getSize(); SHeader.sh_addralign = 1; }