From: Prakash Surya Date: Fri, 11 Jul 2014 20:03:29 +0000 (-0700) Subject: Move metaslab_group_alloc_update() call X-Git-Tag: zfs-0.6.4~231 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=1be627f5c28a355bcd49e4e097114c13fae7731b;p=zfs Move metaslab_group_alloc_update() call This changes moves the called to metaslab_group_alloc_update() to the metaslab_sync_reassess() function. The original placement of the call within metaslab_sync_done() appears to have been a simple mistake, introduced by ac72fac3eaa569902cad88053167f7d74e7fe7e4. This aligns us more closely to the upstream illumos code base. Signed-off-by: Prakash Surya Signed-off-by: Brian Behlendorf --- diff --git a/module/zfs/metaslab.c b/module/zfs/metaslab.c index a8b4b0a0e..fe2428ac0 100644 --- a/module/zfs/metaslab.c +++ b/module/zfs/metaslab.c @@ -1398,8 +1398,6 @@ metaslab_sync_done(metaslab_t *msp, uint64_t txg) vdev_dirty(vd, VDD_METASLAB, msp, txg + 1); } - metaslab_group_alloc_update(mg); - /* * If the map is loaded but no longer active, evict it as soon as all * future allocations have synced. (If we unloaded it now and then @@ -1428,6 +1426,8 @@ metaslab_sync_reassess(metaslab_group_t *mg) int64_t failures = mg->mg_alloc_failures; int m; + metaslab_group_alloc_update(mg); + /* * Re-evaluate all metaslabs which have lower offsets than the * bonus area.