From: Greg Beaver <cellog@php.net>
Date: Mon, 24 Mar 2008 03:05:24 +0000 (+0000)
Subject: a subtle plea for help to Marcus...
X-Git-Tag: RELEASE_2_0_0a1~17
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=1bda8cf708c4053ae70813bd78be6a91b40594c7;p=php

a subtle plea for help to Marcus...
---

diff --git a/ext/phar/phar.c b/ext/phar/phar.c
index a8f551a016..cd1d2b018c 100644
--- a/ext/phar/phar.c
+++ b/ext/phar/phar.c
@@ -1386,6 +1386,7 @@ int phar_detect_phar_fname_ext(const char *filename, int check_length, const cha
 	*ext_str = NULL;
 	for (i = 0; i < sizeof(ext_info) / sizeof(ext_info[0]); ++i) {
 		pos = strstr(filename, ext_info[i].ext);
+		/* Marcus, I don't understand the next line, can you add explanatory comments? XXOO Greg */
 		if (pos && (!ext_info[i].check || pos[ext_info[i].len] != '\0') && (!*ext_str || pos <= *ext_str)) {
 			*ext_str = pos;
 			*ext_len = ext_info[i].len;