From: Jeffrey Yasskin <jyasskin@gmail.com>
Date: Mon, 17 Mar 2008 14:40:53 +0000 (+0000)
Subject: Allow Gnu gcc's to build python on OSX by removing -Wno-long-double,
X-Git-Tag: v2.6a2~308
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=1b4e45bab940d385386e9442de5f5fbc7983dd50;p=python

Allow Gnu gcc's to build python on OSX by removing -Wno-long-double,
-no-cpp-precomp, and -mno-fused-madd from configure.
 * r22183 added -no-cpp-precomp, which
   http://gcc.gnu.org/ml/gcc/2005-12/msg00368.html claims hasn't been
   needed since gcc-3.1.
 * r25607 added -Wno-long-double to avoid a warning in
   Include/objimpl.h (issue 525481). The long double is still there,
   but OSX 10.4's gcc no longer warns about it.
 * r33666 fixed issue 775892 on OSX 10.3 by adding -mno-fused-madd,
   which changed the sign of some float 0s. Tim Peters said it wasn't
   a real issue anyway, and it no longer causes test failures.
Fixes issue #1779871.
---

diff --git a/Misc/NEWS b/Misc/NEWS
index ccb7baabcb..47f8df14c3 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -12,6 +12,10 @@ What's New in Python 2.6 alpha 2?
 Core and builtins
 -----------------
 
+- Issue #1779871: Gnu gcc can now build Python on OS X because the
+  flags -Wno-long-double, -no-cpp-precomp, and -mno-fused-madd are no
+  longer passed.
+
 - Add a warning when asserting a non-empty tuple which is always true.
 
 - Issue #2179: speed up with statement execution by storing the exit method
diff --git a/configure b/configure
index d634f6f800..c7f605874d 100755
--- a/configure
+++ b/configure
@@ -1,5 +1,5 @@
 #! /bin/sh
-# From configure.in Revision: 60765 .
+# From configure.in Revision: 61234 .
 # Guess values for system-dependent variables and create Makefiles.
 # Generated by GNU Autoconf 2.61 for python 2.6.
 #
@@ -4538,7 +4538,8 @@ echo "${ECHO_T}$ac_cv_no_strict_aliasing_ok" >&6; }
 	    ;;
 	# is there any other compiler on Darwin besides gcc?
 	Darwin*)
-	    BASECFLAGS="$BASECFLAGS -Wno-long-double -no-cpp-precomp -mno-fused-madd"
+	    # -Wno-long-double, -no-cpp-precomp, and -mno-fused-madd
+	    # used to be here, but non-Apple gcc doesn't accept them.
 	    if test "${enable_universalsdk}"; then
 		BASECFLAGS="-arch ppc -arch i386 -isysroot ${UNIVERSALSDK} ${BASECFLAGS}"
 	    fi
diff --git a/configure.in b/configure.in
index e7318253da..767766ce45 100644
--- a/configure.in
+++ b/configure.in
@@ -823,7 +823,8 @@ yes)
 	    ;;
 	# is there any other compiler on Darwin besides gcc?
 	Darwin*)
-	    BASECFLAGS="$BASECFLAGS -Wno-long-double -no-cpp-precomp -mno-fused-madd"
+	    # -Wno-long-double, -no-cpp-precomp, and -mno-fused-madd
+	    # used to be here, but non-Apple gcc doesn't accept them.
 	    if test "${enable_universalsdk}"; then
 		BASECFLAGS="-arch ppc -arch i386 -isysroot ${UNIVERSALSDK} ${BASECFLAGS}"
 	    fi