From: Ronnie Sahlberg <sahlberg@google.com>
Date: Fri, 20 Jun 2014 14:42:45 +0000 (-0700)
Subject: refs.c: allow passing NULL to ref_transaction_free
X-Git-Tag: v2.1.0-rc0~22^2~15
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=1b07255c95cdf2f7dbe7989a734248f60799f506;p=git

refs.c: allow passing NULL to ref_transaction_free

Allow ref_transaction_free(NULL) as a no-op. This makes ref_transaction_free
easier to use and more similar to plain 'free'.

In particular, it lets us rollback unconditionally as part of cleanup code
after setting 'transaction = NULL' if a transaction has been committed or
rolled back already.

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Ronnie Sahlberg <sahlberg@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Acked-by: Michael Haggerty <mhagger@alum.mit.edu>
---

diff --git a/refs.c b/refs.c
index 21ed46534a..1d6dece426 100644
--- a/refs.c
+++ b/refs.c
@@ -3338,6 +3338,9 @@ void ref_transaction_free(struct ref_transaction *transaction)
 {
 	int i;
 
+	if (!transaction)
+		return;
+
 	for (i = 0; i < transaction->nr; i++)
 		free(transaction->updates[i]);