From: Matt Beaumont-Gay <matthewbg@google.com>
Date: Tue, 8 Nov 2011 01:53:17 +0000 (+0000)
Subject: Revert r143972, which didn't actually compile under -Wnon-virtual-dtor.
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=1aa1721f14f2162811f5393dbd84e01eadc2c963;p=clang

Revert r143972, which didn't actually compile under -Wnon-virtual-dtor.

(TIL: -Wnon-virtual-dtor is not in -Wall.)

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@144058 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Sema/SemaPseudoObject.cpp b/lib/Sema/SemaPseudoObject.cpp
index cf43fcad05..b70c4ca811 100644
--- a/lib/Sema/SemaPseudoObject.cpp
+++ b/lib/Sema/SemaPseudoObject.cpp
@@ -141,6 +141,8 @@ namespace {
       : S(S), ResultIndex(PseudoObjectExpr::NoResult),
         GenericLoc(genericLoc) {}
 
+    virtual ~PseudoOpBuilder() {}
+
     /// Add a normal semantic expression.
     void addSemanticExpr(Expr *semantic) {
       Semantics.push_back(semantic);
@@ -179,9 +181,6 @@ namespace {
     virtual ExprResult buildGet() = 0;
     virtual ExprResult buildSet(Expr *, SourceLocation,
                                 bool captureSetValueAsResult) = 0;
-
-  protected:
-    ~PseudoOpBuilder() {}
   };
 
   /// A PseudoOpBuilder for Objective-C @properties.