From: Xin Tong <trent.xin.tong@gmail.com>
Date: Thu, 5 Oct 2017 23:00:04 +0000 (+0000)
Subject: [MBP] Remove an invalid assert.
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=1a8db32d9713e383c1b7ae10b6ab5ed64e1182d8;p=llvm

[MBP] Remove an invalid assert.

The patch that this assert comes with is fixing a bug in MBP. The assert is
invalid however.

Thanks to @sergey.k.okunev for finding this

Currently this fails SPECCPU2006 LTO. I will add a test case when I do more
investigation and have one.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@315032 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/CodeGen/MachineBlockPlacement.cpp b/lib/CodeGen/MachineBlockPlacement.cpp
index 12d8a9a0217..c5991332f08 100644
--- a/lib/CodeGen/MachineBlockPlacement.cpp
+++ b/lib/CodeGen/MachineBlockPlacement.cpp
@@ -2240,12 +2240,6 @@ void MachineBlockPlacement::buildLoopChains(const MachineLoop &L) {
   if (!RotateLoopWithProfile && LoopTop == L.getHeader())
     PreferredLoopExit = findBestLoopExit(L, LoopBlockSet);
 
-  // Make sure PreferredLoopExit actually exits the current loop.
-  if (PreferredLoopExit) {
-    assert(L.isLoopExiting(PreferredLoopExit) &&
-           "not an exiting block of current loop");
-  }
-
   BlockChain &LoopChain = *BlockToChain[LoopTop];
 
   // FIXME: This is a really lame way of walking the chains in the loop: we