From: Benjamin Peterson <benjamin@python.org>
Date: Sat, 4 Apr 2015 14:52:36 +0000 (-0400)
Subject: fix refleak in deque_concat
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=1a6292194bdef5f4ee6298b95201b51564d1f93a;p=python

fix refleak in deque_concat
---

diff --git a/Modules/_collectionsmodule.c b/Modules/_collectionsmodule.c
index 9f6c47f54a..2b70b2ba06 100644
--- a/Modules/_collectionsmodule.c
+++ b/Modules/_collectionsmodule.c
@@ -507,7 +507,7 @@ static PyObject *deque_copy(PyObject *deque);
 static PyObject *
 deque_concat(dequeobject *deque, PyObject *other)
 {
-    PyObject *new_deque;
+    PyObject *new_deque, *result;
     int rv;
 
     rv = PyObject_IsInstance(other, (PyObject *)&deque_type);
@@ -523,7 +523,13 @@ deque_concat(dequeobject *deque, PyObject *other)
     new_deque = deque_copy((PyObject *)deque);
     if (new_deque == NULL)
         return NULL;
-    return deque_inplace_concat((dequeobject *)new_deque, other);
+    result = deque_extend((dequeobject *)new_deque, other);
+    if (result == NULL) {
+        Py_DECREF(new_deque);
+        return NULL;
+    }
+    Py_DECREF(result);
+    return new_deque;
 }
 
 static void deque_clear(dequeobject *deque);