From: Heikki Linnakangas <heikki.linnakangas@iki.fi>
Date: Wed, 29 Oct 2014 12:32:01 +0000 (+0200)
Subject: Reset error message at PQreset()
X-Git-Tag: REL9_2_10~99
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=1a27fbd075e8671e0f8a98b3f12b35e86c41109b;p=postgresql

Reset error message at PQreset()

If you call PQreset() repeatedly, and the connection cannot be
re-established, the error messages from the failed connection attempts
kept accumulating in the error string.

Fixes bug #11455 reported by Caleb Epstein. Backpatch to all supported
versions.
---

diff --git a/src/interfaces/libpq/fe-connect.c b/src/interfaces/libpq/fe-connect.c
index 98d2c60b31..8088bdac98 100644
--- a/src/interfaces/libpq/fe-connect.c
+++ b/src/interfaces/libpq/fe-connect.c
@@ -2944,6 +2944,7 @@ closePGconn(PGconn *conn)
 										 * absent */
 	conn->asyncStatus = PGASYNC_IDLE;
 	pqClearAsyncResult(conn);	/* deallocate result */
+	resetPQExpBuffer(&conn->errorMessage);
 	pg_freeaddrinfo_all(conn->addrlist_family, conn->addrlist);
 	conn->addrlist = NULL;
 	conn->addr_cur = NULL;