From: George Burgess IV <george.burgess.iv@gmail.com>
Date: Thu, 12 Jul 2018 21:56:31 +0000 (+0000)
Subject: Remove redundant *_or_null checks; NFC
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=1a14ab01567f14d6b9053a2a540b00f8c63c41c0;p=llvm

Remove redundant *_or_null checks; NFC

For the first one, we dereference `NewDef` right before the `if` anyway.
For the second, we shouldn't have NULL users().


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@336952 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Analysis/MemorySSAUpdater.cpp b/lib/Analysis/MemorySSAUpdater.cpp
index 54184775e97..581fdf50d8b 100644
--- a/lib/Analysis/MemorySSAUpdater.cpp
+++ b/lib/Analysis/MemorySSAUpdater.cpp
@@ -331,7 +331,7 @@ void MemorySSAUpdater::fixupDefs(const SmallVectorImpl<MemoryAccess *> &Vars) {
     auto DefIter = NewDef->getDefsIterator();
 
     // The temporary Phi is being fixed, unmark it for not to optimize.
-    if (MemoryPhi *Phi = dyn_cast_or_null<MemoryPhi>(NewDef))
+    if (MemoryPhi *Phi = dyn_cast<MemoryPhi>(NewDef))
       NonOptPhis.erase(Phi);
 
     // If there is a local def after us, we only have to rename that.
@@ -395,7 +395,7 @@ void MemorySSAUpdater::moveTo(MemoryUseOrDef *What, BasicBlock *BB,
                               WhereType Where) {
   // Mark MemoryPhi users of What not to be optimized.
   for (auto *U : What->users())
-    if (MemoryPhi *PhiUser = dyn_cast_or_null<MemoryPhi>(U))
+    if (MemoryPhi *PhiUser = dyn_cast<MemoryPhi>(U))
       NonOptPhis.insert(PhiUser);
 
   // Replace all our users with our defining access.