From: Victor Stinner Date: Sun, 17 Nov 2013 22:46:34 +0000 (+0100) Subject: test_selectors: test_timeout fails sometimes on busy (slow) buildbots, relax X-Git-Tag: v3.4.0b1~215 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=1a048f93bb62ef1b301de8aa8e422e864db2f423;p=python test_selectors: test_timeout fails sometimes on busy (slow) buildbots, relax the unit test on max time (but be more strict on mon time). Example of failure: http://buildbot.python.org/all/builders/x86%20OpenIndiana%203.x/builds/6978/steps/test/logs/stdio ====================================================================== FAIL: test_timeout (test.test_selectors.PollSelectorTestCase) ---------------------------------------------------------------------- Traceback (most recent call last): File "/export/home/buildbot/32bits/3.x.cea-indiana-x86/build/Lib/test/test_selectors.py", line 316, in test_timeout self.assertTrue(0.5 < t1 - t0 < 1.5, t1 - t0) AssertionError: False is not true : 1.5033390671014786 --- diff --git a/Lib/test/test_selectors.py b/Lib/test/test_selectors.py index c64c87aa3f..f5e67b1005 100644 --- a/Lib/test/test_selectors.py +++ b/Lib/test/test_selectors.py @@ -313,7 +313,8 @@ class BaseSelectorTestCase(unittest.TestCase): t0 = time() self.assertFalse(s.select(1)) t1 = time() - self.assertTrue(0.5 < t1 - t0 < 1.5, t1 - t0) + dt = t1 - t0 + self.assertTrue(0.8 <= dt <= 1.6, dt) @unittest.skipUnless(hasattr(signal, "alarm"), "signal.alarm() required for this test")