From: Marko Kreen <markokr@gmail.com>
Date: Wed, 9 Jan 2013 10:31:48 +0000 (+0200)
Subject: Add missing error checks
X-Git-Tag: pgbouncer_1_6_rc1~43
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=19d7531b98ca291da3fe1918c52ef17a1e2053ec;p=pgbouncer

Add missing error checks
---

diff --git a/src/dnslookup.c b/src/dnslookup.c
index 0c0efe9..403fe85 100644
--- a/src/dnslookup.c
+++ b/src/dnslookup.c
@@ -522,12 +522,15 @@ static void udns_result_a4(struct dns_ctx *ctx, struct dns_rr_a4 *a4, void *data
 	struct addrinfo *res = NULL;
 	int err;
 
-
 	err = dns_status(ctx);
-	if (a4) {
+	if (err < 0) {
+		log_warning("udns_result_a4: %s: query failed [%d]", req->name, err);
+	} else if (a4) {
 		log_noise("udns_result_a4: %s: %d ips", req->name, a4->dnsa4_nrr);
 		res = convert_ipv4_result(a4->dnsa4_addr, a4->dnsa4_nrr);
 		free(a4);
+	} else {
+		log_warning("udns_result_a4: %s: missing result", req->name);
 	}
 	got_result_gai(0, res, req);
 }
diff --git a/src/objects.c b/src/objects.c
index aa4a93c..b1ec5b9 100644
--- a/src/objects.c
+++ b/src/objects.c
@@ -1137,6 +1137,8 @@ void forward_cancel_request(PgSocket *server)
 	Assert(server->state == SV_LOGIN);
 
 	SEND_CancelRequest(res, server, req->cancel_key);
+	if (!res)
+		log_warning("sending cancel request failed: %s", strerror(errno));
 
 	change_client_state(req, CL_JUSTFREE);
 }