From: Andrew M. Kuchling <amk@amk.ca>
Date: Sat, 23 Feb 2008 17:10:46 +0000 (+0000)
Subject: #1433694: minidom's .normalize() failed to set .nextSibling for last element.
X-Git-Tag: v2.6a1~93
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=19aff0c90a1632fce527d7c81769ba419184700c;p=python

#1433694: minidom's .normalize() failed to set .nextSibling for last element.
Fix by Malte Helmert
---

diff --git a/Lib/test/test_minidom.py b/Lib/test/test_minidom.py
index 3058b30306..fcc4c8fec3 100644
--- a/Lib/test/test_minidom.py
+++ b/Lib/test/test_minidom.py
@@ -791,6 +791,14 @@ class MinidomTest(unittest.TestCase):
                 "testNormalize -- single empty node removed")
         doc.unlink()
 
+    def testBug1433694(self):
+        doc = parseString("<o><i/>t</o>")
+        node = doc.documentElement
+        node.childNodes[1].nodeValue = ""
+        node.normalize()
+        self.confirm(node.childNodes[-1].nextSibling == None,
+                     "Final child's .nextSibling should be None")
+
     def testSiblings(self):
         doc = parseString("<doc><?pi?>text?<elm/></doc>")
         root = doc.documentElement
diff --git a/Lib/xml/dom/minidom.py b/Lib/xml/dom/minidom.py
index 40e39f861d..ae960330c5 100644
--- a/Lib/xml/dom/minidom.py
+++ b/Lib/xml/dom/minidom.py
@@ -203,6 +203,8 @@ class Node(xml.dom.Node):
                 L.append(child)
                 if child.nodeType == Node.ELEMENT_NODE:
                     child.normalize()
+        if L:
+            L[-1].nextSibling = None
         self.childNodes[:] = L
 
     def cloneNode(self, deep):
diff --git a/Misc/ACKS b/Misc/ACKS
index 8c037840db..794b1f427d 100644
--- a/Misc/ACKS
+++ b/Misc/ACKS
@@ -274,6 +274,7 @@ Shane Hathaway
 Rycharde Hawkes
 Jochen Hayek
 Thomas Heller
+Malte Helmert
 Lance Finn Helsten
 Jonathan Hendry
 James Henstridge