From: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Date: Tue, 5 Jun 2018 13:47:42 +0000 (-0700)
Subject: bpo-33752: Fix a file leak in test_dbm. (GH-7376)
X-Git-Tag: v3.6.6rc1~40
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=194a5c07228342106c98dcf85c8a5f4cd2c8b04e;p=python

bpo-33752: Fix a file leak in test_dbm. (GH-7376)


With addCleanup() f.close() was executed after tearDown().
(cherry picked from commit 6592d7fe11477f8f974d2d4a85c3382a1ad05217)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
---

diff --git a/Lib/test/test_dbm.py b/Lib/test/test_dbm.py
index 78c32c4c93..1884b5c683 100644
--- a/Lib/test/test_dbm.py
+++ b/Lib/test/test_dbm.py
@@ -75,10 +75,8 @@ class AnyDBMTestCase:
     def test_anydbm_creation_n_file_exists_with_invalid_contents(self):
         # create an empty file
         test.support.create_empty_file(_fname)
-
-        f = dbm.open(_fname, 'n')
-        self.addCleanup(f.close)
-        self.assertEqual(len(f), 0)
+        with dbm.open(_fname, 'n') as f:
+            self.assertEqual(len(f), 0)
 
     def test_anydbm_modification(self):
         self.init_db()