From: Gregory P. Smith <greg@krypto.org>
Date: Fri, 1 Feb 2013 19:31:31 +0000 (-0800)
Subject: Fixes Issue #6972: The zipfile module no longer overwrites files outside of
X-Git-Tag: v3.3.1rc1~256^2~2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=193e1be72d2f9bb45e054b38dd9ed1090c45f3bf;p=python

Fixes Issue #6972: The zipfile module no longer overwrites files outside of
its destination path when extracting malicious zip files.
---

193e1be72d2f9bb45e054b38dd9ed1090c45f3bf
diff --cc Lib/test/test_zipfile.py
index b0c529fb94,85cd0742b7..81e30368e0
--- a/Lib/test/test_zipfile.py
+++ b/Lib/test/test_zipfile.py
@@@ -539,9 -441,86 +533,83 @@@ class TestsWithSourceFile(unittest.Test
          # remove the test file subdirectories
          shutil.rmtree(os.path.join(os.getcwd(), 'ziptest2dir'))
  
+     def check_file(self, filename, content):
+         self.assertTrue(os.path.isfile(filename))
+         with open(filename, 'rb') as f:
+             self.assertEqual(f.read(), content)
+ 
+     def test_extract_hackers_arcnames(self):
+         hacknames = [
+             ('../foo/bar', 'foo/bar'),
+             ('foo/../bar', 'foo/bar'),
+             ('foo/../../bar', 'foo/bar'),
+             ('foo/bar/..', 'foo/bar'),
+             ('./../foo/bar', 'foo/bar'),
+             ('/foo/bar', 'foo/bar'),
+             ('/foo/../bar', 'foo/bar'),
+             ('/foo/../../bar', 'foo/bar'),
+             ('//foo/bar', 'foo/bar'),
+             ('../../foo../../ba..r', 'foo../ba..r'),
+         ]
+         if os.path.sep == '\\':  # Windows.
+             hacknames.extend([
+                 (r'..\foo\bar', 'foo/bar'),
+                 (r'..\/foo\/bar', 'foo/bar'),
+                 (r'foo/\..\/bar', 'foo/bar'),
+                 (r'foo\/../\bar', 'foo/bar'),
+                 (r'C:foo/bar', 'foo/bar'),
+                 (r'C:/foo/bar', 'foo/bar'),
+                 (r'C://foo/bar', 'foo/bar'),
+                 (r'C:\foo\bar', 'foo/bar'),
+                 (r'//conky/mountpoint/foo/bar', 'foo/bar'),
+                 (r'\\conky\mountpoint\foo\bar', 'foo/bar'),
+                 (r'///conky/mountpoint/foo/bar', 'conky/mountpoint/foo/bar'),
+                 (r'\\\conky\mountpoint\foo\bar', 'conky/mountpoint/foo/bar'),
+                 (r'//conky//mountpoint/foo/bar', 'conky/mountpoint/foo/bar'),
+                 (r'\\conky\\mountpoint\foo\bar', 'conky/mountpoint/foo/bar'),
+                 (r'//?/C:/foo/bar', 'foo/bar'),
+                 (r'\\?\C:\foo\bar', 'foo/bar'),
+                 (r'C:/../C:/foo/bar', 'C_/foo/bar'),
+                 (r'a:b\c<d>e|f"g?h*i', 'b/c_d_e_f_g_h_i'),
+             ])
+ 
+         for arcname, fixedname in hacknames:
+             content = b'foobar' + arcname.encode()
+             with zipfile.ZipFile(TESTFN2, 'w', zipfile.ZIP_STORED) as zipfp:
+                 zipfp.writestr(arcname, content)
+ 
+             targetpath = os.path.join('target', 'subdir', 'subsub')
+             correctfile = os.path.join(targetpath, *fixedname.split('/'))
+ 
+             with zipfile.ZipFile(TESTFN2, 'r') as zipfp:
+                 writtenfile = zipfp.extract(arcname, targetpath)
+                 self.assertEqual(writtenfile, correctfile)
+             self.check_file(correctfile, content)
+             shutil.rmtree('target')
+ 
+             with zipfile.ZipFile(TESTFN2, 'r') as zipfp:
+                 zipfp.extractall(targetpath)
+             self.check_file(correctfile, content)
+             shutil.rmtree('target')
+ 
+             correctfile = os.path.join(os.getcwd(), *fixedname.split('/'))
+ 
+             with zipfile.ZipFile(TESTFN2, 'r') as zipfp:
+                 writtenfile = zipfp.extract(arcname)
+                 self.assertEqual(writtenfile, correctfile)
+             self.check_file(correctfile, content)
+             shutil.rmtree(fixedname.split('/')[0])
+ 
+             with zipfile.ZipFile(TESTFN2, 'r') as zipfp:
+                 zipfp.extractall()
+             self.check_file(correctfile, content)
+             shutil.rmtree(fixedname.split('/')[0])
+ 
+             os.remove(TESTFN2)
+ 
 -    def test_writestr_compression(self):
 +    def test_writestr_compression_stored(self):
          zipfp = zipfile.ZipFile(TESTFN2, "w")
          zipfp.writestr("a.txt", "hello world", compress_type=zipfile.ZIP_STORED)
 -        if zlib:
 -            zipfp.writestr("b.txt", "hello world", compress_type=zipfile.ZIP_DEFLATED)
 -
          info = zipfp.getinfo('a.txt')
          self.assertEqual(info.compress_type, zipfile.ZIP_STORED)