From: Christoph M. Becker Date: Mon, 12 Aug 2019 08:01:30 +0000 (+0200) Subject: Don't explicitly set return value on ZPP failure X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=193dcec529b86dcaed7e81ef79d8b837d9a7cea7;p=php Don't explicitly set return value on ZPP failure Failing ZPP throws as of PHP 8.0.0, so explicitly setting a return value is useless, and also slightly confusing. --- diff --git a/ext/com_dotnet/com_com.c b/ext/com_dotnet/com_com.c index a16d5396d8..f9d88603c7 100644 --- a/ext/com_dotnet/com_com.c +++ b/ext/com_dotnet/com_com.c @@ -701,7 +701,7 @@ PHP_FUNCTION(com_event_sink) if (FAILURE == zend_parse_parameters(ZEND_NUM_ARGS(), "Oo|z/", &object, php_com_variant_class_entry, &sinkobject, &sink)) { - RETURN_FALSE; + return; } php_com_initialize(); @@ -762,7 +762,7 @@ PHP_FUNCTION(com_print_typeinfo) if (FAILURE == zend_parse_parameters(ZEND_NUM_ARGS(), "z/|s!b", &arg1, &ifacename, &ifacelen, &wantsink)) { - RETURN_FALSE; + return; } php_com_initialize();