From: foobar <sniper@php.net>
Date: Wed, 8 Oct 2003 11:16:22 +0000 (+0000)
Subject: - Reverted the 'fix' for bug #25494
X-Git-Tag: php-4.3.4RC2~33
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=18a2f7bab4fad2648a8839e50e57aea9a9132d92;p=php

- Reverted the 'fix' for bug #25494
# Can we now get peace on internals@ about this stupid issue?
---

diff --git a/NEWS b/NEWS
index 4cfb1b5410..7031abcb66 100644
--- a/NEWS
+++ b/NEWS
@@ -43,7 +43,6 @@ PHP 4                                                                      NEWS
   (Sara, patch by: mikael dot suvi at trigger dot ee)
 - Fixed bug #25504 (pcre_match_all() crashes when passed only 2 parameters).
   (Jani)
-- Fixed bug #25494 (array_merge*() allows non-arrays as argument). (Jay)
 - Fixed bug #23488 (zlib.output_compression overrides Vary header). (Stefan)
 - Fixed bug #25483 (ext/informix: bogus -469 error from ifx_query()). 
   (Jani, patch by: denisov at kubsu dot ru)
diff --git a/ext/standard/array.c b/ext/standard/array.c
index d78943f65b..7052c35778 100644
--- a/ext/standard/array.c
+++ b/ext/standard/array.c
@@ -2054,9 +2054,6 @@ static void php_array_merge_wrapper(INTERNAL_FUNCTION_PARAMETERS, int recursive)
 	array_init(return_value);
 	
 	for (i=0; i<argc; i++) {
-		if (Z_TYPE_PP(args[i]) != IS_ARRAY) {
-			php_error_docref(NULL TSRMLS_CC, E_NOTICE, "Argument #%d is not an array", i+1);
-		}
 		SEPARATE_ZVAL(args[i]);
 		convert_to_array_ex(args[i]);
 		php_array_merge(Z_ARRVAL_P(return_value), Z_ARRVAL_PP(args[i]), recursive TSRMLS_CC);