From: Shlomi Fish <shlomif@shlomifish.org>
Date: Sat, 18 Jan 2020 14:45:59 +0000 (+0200)
Subject: Extract a common expression into a variable/const.
X-Git-Tag: fortune-mod-2.14.0~17
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=188874ae9ae72745410c15bfcff8327dec43ca94;p=fortune-mod

Extract a common expression into a variable/const.

This is Refactoring / code cleanup.

See:

* https://refactoring.com/catalog/extractMethod.html

* https://en.wikipedia.org/wiki/Code_refactoring

* https://www.refactoring.com/

* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/

Some small optimisations may have slipped in as well.
---

diff --git a/CI-testing/continuous-integration-testing.pl b/CI-testing/continuous-integration-testing.pl
index 2085349..7a3ed7f 100644
--- a/CI-testing/continuous-integration-testing.pl
+++ b/CI-testing/continuous-integration-testing.pl
@@ -84,10 +84,11 @@ if ($IS_WIN)
 chdir($cwd);
 $cwd->child('B')->remove_tree( { safe => 0, } );
 
+my $WIN32__DOUBLE_AMPERSAND__PROPER_HANDLING__NEEDED_PREFIX = "cd . &&";
 do_system(
     {
         cmd => [
-            "cd . && mkdir B && cd B && cmake"
+"$WIN32__DOUBLE_AMPERSAND__PROPER_HANDLING__NEEDED_PREFIX mkdir B && cd B && cmake"
                 . (
                 defined($CMAKE_PREFIX_PATH)
                 ? ( " -DCMAKE_PREFIX_PATH=" . _transform($CMAKE_PREFIX_PATH) )