From: Regina Obe <lr@pcorp.us>
Date: Sat, 23 Aug 2014 05:31:33 +0000 (+0000)
Subject: #2899 geocode limit 1 not always returning best answer
X-Git-Tag: 2.2.0rc1~878
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=180d6c141916b9c4565bbfd12ab6f90f2b351e9f;p=postgis

#2899 geocode limit 1 not always returning best answer

git-svn-id: http://svn.osgeo.org/postgis/trunk@12914 b70326c6-7e19-0410-871a-916f4a2858ee
---

diff --git a/extras/tiger_geocoder/tiger_2011/geocode/geocode_address.sql b/extras/tiger_geocoder/tiger_2011/geocode/geocode_address.sql
index 1e74da877..333e265f6 100644
--- a/extras/tiger_geocoder/tiger_2011/geocode/geocode_address.sql
+++ b/extras/tiger_geocoder/tiger_2011/geocode/geocode_address.sql
@@ -177,7 +177,7 @@ BEGIN
             ) AS sub 
           JOIN state s ON ($10 = s.statefp) 
             ORDER BY 1,2,3,4,5,6,7,9 
-          LIMIT 20) As foo ORDER BY sub_rating, exact_address DESC LIMIT  ' || max_results ;
+          LIMIT 20) As foo ORDER BY sub_rating, exact_address DESC LIMIT  ' || max_results*10 ;
          
   IF var_debug THEN
          RAISE NOTICE 'stmt: %', 
@@ -235,7 +235,7 @@ BEGIN
             RETURN;
         END IF;
     
-        IF var_n >= max_results  THEN --we have exceeded our desired limit
+        IF var_n >= max_results AND RATING < 10  THEN --we have exceeded our desired limit and rating is not horrible
             RETURN;
         END IF;
     
diff --git a/extras/tiger_geocoder/tiger_2011/regress/geocode_regress b/extras/tiger_geocoder/tiger_2011/regress/geocode_regress
index 2f8f6d386..3d3dc78db 100644
--- a/extras/tiger_geocoder/tiger_2011/regress/geocode_regress
+++ b/extras/tiger_geocoder/tiger_2011/regress/geocode_regress
@@ -80,3 +80,4 @@ T18b|26 Court St, Boston, MA 02108|POINT(-71.05885 42.35911)|1
 #1392a|State Hwy 121, Coppell, TX|POINT(-96.993397 32.985954)|8
 #1392b|State Hwy 121, Coppell, TX|POINT(-96.993416 32.987025)|18
 #1392b|State Hwy 121, Coppell, TX|POINT(-96.993397 32.985954)|18
+#2899|POINT(-72.4863 41.2807)|0
diff --git a/extras/tiger_geocoder/tiger_2011/regress/geocode_regress.sql b/extras/tiger_geocoder/tiger_2011/regress/geocode_regress.sql
index c7c7556c3..a9f939c43 100644
--- a/extras/tiger_geocoder/tiger_2011/regress/geocode_regress.sql
+++ b/extras/tiger_geocoder/tiger_2011/regress/geocode_regress.sql
@@ -103,4 +103,7 @@ SELECT '#1333b' AS ticket, pprint_addy(addy), st_astext(geomout),rating FROM geo
 SELECT '#1392a' AS ticket, pprint_addy(addy), st_astext(geomout),rating FROM geocode_intersection('State Hwy 121', 'N Denton Tap Rd', 'TX', 'Coppell', '', 2);
 SELECT '#1392b' AS ticket, pprint_addy(addy), st_astext(geomout),rating FROM geocode_intersection('State Hwy 121', 'N Denton Tap Rd', 'TX','', '', 2);
 --
+
+-- Geocode 1 not returning best answer
+SELECT '#2899' AS ticket, st_astext(ST_SnapToGrid(geomout,0.0001)),rating FROM geocode('22 Minnow Ln, Westbrook, CT 06498',1);
 \timing