From: Tom Lane Date: Fri, 12 May 2006 22:44:43 +0000 (+0000) Subject: Fix the sense of the test on DH_check()'s return value. This was preventing X-Git-Tag: REL8_1_4~16 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=17e048603c6efc1b74783d7e79e930498c3c37a2;p=postgresql Fix the sense of the test on DH_check()'s return value. This was preventing custom-generated DH parameters from actually being used by the server. Found by Michael Fuhr. --- diff --git a/src/backend/libpq/be-secure.c b/src/backend/libpq/be-secure.c index fa1de916a1..56fefae95a 100644 --- a/src/backend/libpq/be-secure.c +++ b/src/backend/libpq/be-secure.c @@ -11,7 +11,7 @@ * * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/libpq/be-secure.c,v 1.59.2.1 2005/11/22 18:23:09 momjian Exp $ + * $PostgreSQL: pgsql/src/backend/libpq/be-secure.c,v 1.59.2.2 2006/05/12 22:44:43 tgl Exp $ * * Since the server static private key ($DataDir/server.key) * will normally be stored unencrypted so that the database @@ -525,7 +525,7 @@ load_dh_file(int keylength) /* make sure the DH parameters are usable */ if (dh != NULL) { - if (DH_check(dh, &codes)) + if (DH_check(dh, &codes) == 0) { elog(LOG, "DH_check error (%s): %s", fnbuf, SSLerrmessage()); return NULL;