From: Gunnar Beutner <gunnar@beutner.name>
Date: Mon, 30 Mar 2015 11:39:24 +0000 (+0200)
Subject: Fix permissions for agent CheckResult messages
X-Git-Tag: v2.3.4~25
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=17c929aabf842f793a8faf05ec426de212956665;p=icinga2

Fix permissions for agent CheckResult messages

fixes #8821
---

diff --git a/lib/icinga/apievents.cpp b/lib/icinga/apievents.cpp
index be235d38f..9e898cae4 100644
--- a/lib/icinga/apievents.cpp
+++ b/lib/icinga/apievents.cpp
@@ -193,7 +193,10 @@ Value ApiEvents::CheckResultAPIHandler(const MessageOrigin& origin, const Dictio
 	if (origin.FromZone && !origin.FromZone->CanAccessObject(checkable) && endpoint != checkable->GetCommandEndpoint())
 		return Empty;
 
-	checkable->ProcessCheckResult(cr, origin);
+	if (endpoint == checkable->GetCommandEndpoint())
+		checkable->ProcessCheckResult(cr);
+	else
+		checkable->ProcessCheckResult(cr, origin);
 
 	return Empty;
 }
diff --git a/lib/icinga/checkable-check.cpp b/lib/icinga/checkable-check.cpp
index a4da0c31d..bc4cacd12 100644
--- a/lib/icinga/checkable-check.cpp
+++ b/lib/icinga/checkable-check.cpp
@@ -268,25 +268,6 @@ void Checkable::ProcessCheckResult(const CheckResult::Ptr& cr, const MessageOrig
 			/* send message back to its origin */
 			Dictionary::Ptr message = ApiEvents::MakeCheckResultMessage(this, cr);
 			listener->SyncSendMessage(command_endpoint, message);
-
-			/* HA cluster zone nodes must also process the check result locally
-			 * by fetching the real host/service object if existing
-			 */
-			Host::Ptr tempHost;
-			Service::Ptr tempService;
-			tie(tempHost, tempService) = GetHostService(this);
-			Host::Ptr realHost = Host::GetByName(tempHost->GetName());
-			if (realHost) {
-				Value agent_service_name = GetExtension("agent_service_name");
-				if (!agent_service_name.IsEmpty()) {
-					Checkable::Ptr realCheckable;
-					realCheckable = realHost->GetServiceByShortName(agent_service_name);
-					if (realCheckable) {
-						realCheckable->ProcessCheckResult(cr, origin);
-					}
-				}
-			}
-
 		}
 
 		return;