From: Ian Holsman <ianh@apache.org>
Date: Tue, 17 Jul 2001 21:43:35 +0000 (+0000)
Subject: Change the APR_INHERIT flag to APR_NO_INHERIT,which is the default (as recommended... 
X-Git-Tag: 2.0.21~46
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=175af69f8ee0c6286bc199dc244d9bb48516ab6c;p=apache

Change the APR_INHERIT flag to APR_NO_INHERIT,which is the default (as recommended by rbb)

PR:
Obtained from:
Submitted by:
Reviewed by:


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@89569 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/modules/proxy/proxy_connect.c b/modules/proxy/proxy_connect.c
index 766073c089..82dd7337d6 100644
--- a/modules/proxy/proxy_connect.c
+++ b/modules/proxy/proxy_connect.c
@@ -216,7 +216,7 @@ int ap_proxy_connect_handler(request_rec *r, proxy_server_conf *conf,
     }
 
     /* create a new socket */
-    if ((rv = apr_socket_create(&sock, APR_INET, SOCK_STREAM,APR_INHERIT, r->pool)) != APR_SUCCESS) {
+    if ((rv = apr_socket_create(&sock, APR_INET, SOCK_STREAM,APR_NO_INHERIT, r->pool)) != APR_SUCCESS) {
         ap_log_rerror(APLOG_MARK, APLOG_ERR, rv, r,
             "proxy: error creating socket");
         return HTTP_INTERNAL_SERVER_ERROR;
diff --git a/modules/proxy/proxy_ftp.c b/modules/proxy/proxy_ftp.c
index 7e25bbdff2..0bc8fc60b7 100644
--- a/modules/proxy/proxy_ftp.c
+++ b/modules/proxy/proxy_ftp.c
@@ -673,7 +673,7 @@ int ap_proxy_ftp_handler(request_rec *r, proxy_server_conf *conf,
     }
 
 
-    if ((rv = apr_socket_create(&sock, APR_INET, SOCK_STREAM, APR_INHERIT, r->pool)) != APR_SUCCESS) {
+    if ((rv = apr_socket_create(&sock, APR_INET, SOCK_STREAM, APR_NO_INHERIT, r->pool)) != APR_SUCCESS) {
         ap_log_rerror(APLOG_MARK, APLOG_ERR, rv, r,
                       "proxy: FTP: error creating socket");
         return HTTP_INTERNAL_SERVER_ERROR;
@@ -1038,7 +1038,7 @@ int ap_proxy_ftp_handler(request_rec *r, proxy_server_conf *conf,
                              "proxy: FTP: EPSV contacting remote host on port %d",
                              remote_port);
 
-		if ((rv = apr_socket_create(&remote_sock, APR_INET, SOCK_STREAM, APR_INHERIT, r->pool)) != APR_SUCCESS) {
+		if ((rv = apr_socket_create(&remote_sock, APR_INET, SOCK_STREAM, APR_NO_INHERIT, r->pool)) != APR_SUCCESS) {
 		    ap_log_rerror(APLOG_MARK, APLOG_ERR, rv, r,
 			          "proxy: FTP: error creating EPSV socket");
 		    return HTTP_INTERNAL_SERVER_ERROR;
@@ -1132,7 +1132,7 @@ int ap_proxy_ftp_handler(request_rec *r, proxy_server_conf *conf,
                              "proxy: FTP: PASV contacting host %d.%d.%d.%d:%d",
                              h3, h2, h1, h0, pasvport);
 
-		if ((rv = apr_socket_create(&remote_sock, APR_INET, SOCK_STREAM, APR_INHERIT, r->pool)) != APR_SUCCESS) {
+		if ((rv = apr_socket_create(&remote_sock, APR_INET, SOCK_STREAM, APR_NO_INHERIT, r->pool)) != APR_SUCCESS) {
 		    ap_log_rerror(APLOG_MARK, APLOG_ERR, rv, r,
 			          "proxy: error creating PASV socket");
 		    return HTTP_INTERNAL_SERVER_ERROR;
@@ -1174,7 +1174,7 @@ int ap_proxy_ftp_handler(request_rec *r, proxy_server_conf *conf,
 	apr_port_t local_port;
 	unsigned int h0, h1, h2, h3, p0, p1;
 
-	if ((rv = apr_socket_create(&local_sock, APR_INET, SOCK_STREAM, APR_INHERIT, r->pool)) != APR_SUCCESS) {
+	if ((rv = apr_socket_create(&local_sock, APR_INET, SOCK_STREAM, APR_NO_INHERIT, r->pool)) != APR_SUCCESS) {
 	    ap_log_rerror(APLOG_MARK, APLOG_ERR, rv, r,
 			 "proxy: FTP: error creating local socket");
 	    return HTTP_INTERNAL_SERVER_ERROR;
diff --git a/modules/proxy/proxy_http.c b/modules/proxy/proxy_http.c
index 2d899c7f32..d1dcd2cf2d 100644
--- a/modules/proxy/proxy_http.c
+++ b/modules/proxy/proxy_http.c
@@ -363,7 +363,7 @@ int ap_proxy_http_handler(request_rec *r, proxy_server_conf *conf,
 	backend->connection = NULL;
 
 	/* see memory note above */
-	if ((rv = apr_socket_create(&sock, APR_INET, SOCK_STREAM, APR_INHERIT, c->pool)) != APR_SUCCESS) {
+	if ((rv = apr_socket_create(&sock, APR_INET, SOCK_STREAM, APR_NO_INHERIT, c->pool)) != APR_SUCCESS) {
             ap_log_error(APLOG_MARK, APLOG_ERR, rv, r->server,
 			 "proxy: error creating socket");
 	    return HTTP_INTERNAL_SERVER_ERROR;