From: Ilia Alshanetsky <iliaa@php.net>
Date: Tue, 4 Feb 2003 18:34:10 +0000 (+0000)
Subject: MFH
X-Git-Tag: php-4.3.2RC1~336
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=16f626702dc0d1e1bdab6a85d21c26b54c474c6d;p=php

MFH
---

diff --git a/ext/pgsql/pgsql.c b/ext/pgsql/pgsql.c
index a8a24193d4..b72931119f 100644
--- a/ext/pgsql/pgsql.c
+++ b/ext/pgsql/pgsql.c
@@ -1437,23 +1437,18 @@ PHP_FUNCTION(pg_result_seek)
 	int row;
 	pgsql_result_handle *pg_result;
 
-	if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "r|l",
-							  &result, &row) == FAILURE) {
+	if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "rl", &result, &row) == FAILURE) {
 		return;
 	}
 
 	ZEND_FETCH_RESOURCE(pg_result, pgsql_result_handle *, &result, -1, "PostgreSQL result", le_result);
 
-	/* Let see if we are better to have another function for this */
-	/* if offset is omitted, return current position */
-/* 	if (ZEND_NUM_ARGS() == 1) */
-/* 		RETURN_LONG(pg_result->row); */
-
-	if (row < 0 || row >= PQntuples(pg_result->result))
+	if (row < 0 || row >= PQntuples(pg_result->result)) {
 		RETURN_FALSE;
+	}
 	
 	/* seek to offset */
-	pg_result->row = row;
+	pg_result->row = row - 1;
 	RETURN_TRUE;
 }
 /* }}} */