From: Ilia Alshanetsky Date: Fri, 1 Dec 2006 19:10:59 +0000 (+0000) Subject: MFB: Fixed a possible memory corruption in dbase_open() with invalid open X-Git-Tag: RELEASE_1_0_0RC1~858 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=16c58e611ab983df463da4f08bc77d25f2607314;p=php MFB: Fixed a possible memory corruption in dbase_open() with invalid open mode --- diff --git a/ext/dbase/dbase.c b/ext/dbase/dbase.c index 23fd5eb629..6859ecacec 100644 --- a/ext/dbase/dbase.c +++ b/ext/dbase/dbase.c @@ -136,7 +136,7 @@ PHP_FUNCTION(dbase_open) if (Z_LVAL_PP(options) == 1) { php_error_docref(NULL TSRMLS_CC, E_WARNING, "Cannot open %s in write-only mode", Z_STRVAL_PP(dbf_name)); RETURN_FALSE; - } else if (Z_LVAL_PP(options) < 0) { + } else if (Z_LVAL_PP(options) < 0 || Z_LVAL_PP(options) > 3) { php_error_docref(NULL TSRMLS_CC, E_WARNING, "Invalid access mode %ld", Z_LVAL_PP(options)); RETURN_FALSE; } diff --git a/ext/dbase/tests/002.phpt b/ext/dbase/tests/002.phpt index 408c87c30b..f76be4f263 100644 --- a/ext/dbase/tests/002.phpt +++ b/ext/dbase/tests/002.phpt @@ -38,7 +38,7 @@ echo "Done\n"; Warning: dbase_open(): Invalid access mode -1 %s in %s on line %d bool(false) -Warning: dbase_open(): unable to open database %s in %s on line %d +Warning: dbase_open(): Invalid access mode 1000 in %s on line %d bool(false) Warning: dbase_open(): unable to open database %s in %s on line %d