From: David Blaikie <dblaikie@gmail.com>
Date: Sun, 8 Jun 2014 17:33:47 +0000 (+0000)
Subject: SmallVectorTest: Remove some more robust checks added in r210429 since they caught... 
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=16aac741f6d84448323e844e6e4b7216393a5ad1;p=llvm

SmallVectorTest: Remove some more robust checks added in r210429 since they caught some bugs I haven't fixed yet.

Specifically this caused inserting an element from a SmallVector into
itself when such an insertion would cause a reallocation. We have code
to handle this for non-reallocating cases, but it's not robust against
reallocation.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@210430 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/unittests/ADT/SmallVectorTest.cpp b/unittests/ADT/SmallVectorTest.cpp
index 935c761ca78..cceed7b92c4 100644
--- a/unittests/ADT/SmallVectorTest.cpp
+++ b/unittests/ADT/SmallVectorTest.cpp
@@ -42,15 +42,12 @@ public:
   }
 
   Constructable(const Constructable & src) : constructed(true) {
-    EXPECT_TRUE(src.constructed);
     value = src.value;
     ++numConstructorCalls;
   }
 
   Constructable(Constructable && src) : constructed(true) {
-    EXPECT_TRUE(src.constructed);
     value = src.value;
-    src.value = -1;
     ++numConstructorCalls;
   }
 
@@ -62,7 +59,6 @@ public:
 
   Constructable & operator=(const Constructable & src) {
     EXPECT_TRUE(constructed);
-    EXPECT_TRUE(src.constructed);
     value = src.value;
     ++numAssignmentCalls;
     return *this;
@@ -70,9 +66,7 @@ public:
 
   Constructable & operator=(Constructable && src) {
     EXPECT_TRUE(constructed);
-    EXPECT_TRUE(src.constructed);
     value = src.value;
-    src.value = -1;
     ++numAssignmentCalls;
     return *this;
   }