From: Michal Gorny Date: Mon, 3 Jun 2019 14:50:03 +0000 (+0000) Subject: [llvm] [test] Remove non-portable EISDIR test from macho-disassemble-g-dsym.test X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=1693ea9e85fda977acbb99f1c7bdb795a7fee35f;p=llvm [llvm] [test] Remove non-portable EISDIR test from macho-disassemble-g-dsym.test Remove the test checking error message for 'is a directory'. It does not seem to serve any real purpose, and it relies on matching platform error strings which are unpredictable and makes the test fragile. Furthermore, it fails on NetBSD where read() works on directories, and therefore does not return EISDIR at all. Fixes r362141. Differential Revision: https://reviews.llvm.org/D62773 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@362404 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/test/tools/llvm-objdump/X86/macho-disassemble-g-dsym.test b/test/tools/llvm-objdump/X86/macho-disassemble-g-dsym.test index c9f72fa752b..94ef98ab9f6 100644 --- a/test/tools/llvm-objdump/X86/macho-disassemble-g-dsym.test +++ b/test/tools/llvm-objdump/X86/macho-disassemble-g-dsym.test @@ -15,8 +15,3 @@ MACHO_DSYM: (__TEXT,__text) section // RUN: llvm-objdump -m -d -g -dsym %p/../Inputs/libbogus11.a %p/../../dsymutil/Inputs/basic.macho.x86_64 2>&1 | FileCheck -check-prefix BAD_INPUT %s BAD_INPUT: is not a Mach-O or Universal file type. - -// RUN: not llvm-objdump -m -d -g -dsym %p/Inputs %p/Inputs/hello-macho-thin 2>&1 | FileCheck -check-prefix DIRECTORY %s - -// Windows will emit "Is a directory", whereas others emit "is a directory" -DIRECTORY: {{[i|I]}}s a directory