From: Antoine Pitrou <solipsis@pitrou.net>
Date: Fri, 30 Oct 2009 21:41:22 +0000 (+0000)
Subject: Try to fix transient refleaks in test_pydoc.
X-Git-Tag: v2.7a1~188
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=161df94b0db778b53276bc54bdb282dfb47ccdb4;p=python

Try to fix transient refleaks in test_pydoc.
---

diff --git a/Lib/test/test_pydoc.py b/Lib/test/test_pydoc.py
index 0faf4a161a..3eeb738764 100644
--- a/Lib/test/test_pydoc.py
+++ b/Lib/test/test_pydoc.py
@@ -9,7 +9,8 @@ import inspect
 import unittest
 import test.test_support
 from contextlib import contextmanager
-from test.test_support import TESTFN, forget, rmtree, EnvironmentVarGuard
+from test.test_support import (
+    TESTFN, forget, rmtree, EnvironmentVarGuard, reap_children)
 
 from test import pydoc_mod
 
@@ -178,8 +179,11 @@ def run_pydoc(module_name, *args):
     output of pydoc.
     """
     cmd = [sys.executable, pydoc.__file__, " ".join(args), module_name]
-    output = subprocess.Popen(cmd, stdout=subprocess.PIPE).stdout.read()
-    return output.strip()
+    try:
+        output = subprocess.Popen(cmd, stdout=subprocess.PIPE).communicate()[0]
+        return output.strip()
+    finally:
+        reap_children()
 
 def get_pydoc_html(module):
     "Returns pydoc generated output as html"