From: Nikita Popov <nikita.ppv@gmail.com>
Date: Wed, 14 Oct 2020 09:43:22 +0000 (+0200)
Subject: Mark ldap_exop() param as UNKNOWN
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=1610e81b5105579bfa69e413cee224c661db16d7;p=php

Mark ldap_exop() param as UNKNOWN

This function actually has very different behavior depending on
whether $response_data is passed or not.
---

diff --git a/ext/ldap/ldap.stub.php b/ext/ldap/ldap.stub.php
index 0aad23a165..b49472f954 100644
--- a/ext/ldap/ldap.stub.php
+++ b/ext/ldap/ldap.stub.php
@@ -279,7 +279,7 @@ function ldap_8859_to_t61(string $value): string|false {}
  * @param string $response_oid
  * @return resource|bool
  */
-function ldap_exop($ldap, string $request_oid, ?string $request_data = null, ?array $controls = [], &$response_data = null, &$response_oid = null) {}
+function ldap_exop($ldap, string $request_oid, ?string $request_data = null, ?array $controls = [], &$response_data = UNKNOWN, &$response_oid = null) {}
 #endif
 
 #ifdef HAVE_LDAP_PASSWD
diff --git a/ext/ldap/ldap_arginfo.h b/ext/ldap/ldap_arginfo.h
index a0b5890cad..3c02df966d 100644
--- a/ext/ldap/ldap_arginfo.h
+++ b/ext/ldap/ldap_arginfo.h
@@ -1,5 +1,5 @@
 /* This is a generated file, edit the .stub.php file instead.
- * Stub hash: 42f7118d8380424cd4178759cae6cb47b6d9b44f */
+ * Stub hash: 0c02f5e91a47e9664c8c41332bf8040e93592753 */
 
 #if defined(HAVE_ORALDAP)
 ZEND_BEGIN_ARG_INFO_EX(arginfo_ldap_connect, 0, 0, 0)
@@ -297,7 +297,7 @@ ZEND_BEGIN_ARG_INFO_EX(arginfo_ldap_exop, 0, 0, 2)
 	ZEND_ARG_TYPE_INFO(0, request_oid, IS_STRING, 0)
 	ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, request_data, IS_STRING, 1, "null")
 	ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, controls, IS_ARRAY, 1, "[]")
-	ZEND_ARG_INFO_WITH_DEFAULT_VALUE(1, response_data, "null")
+	ZEND_ARG_INFO(1, response_data)
 	ZEND_ARG_INFO_WITH_DEFAULT_VALUE(1, response_oid, "null")
 ZEND_END_ARG_INFO()
 #endif