From: Alvaro Herrera <alvherre@alvh.no-ip.org>
Date: Sun, 25 Jun 2006 04:38:00 +0000 (+0000)
Subject: Our version of getopt_long does not set optarg upon detecting an error, as
X-Git-Tag: REL8_1_5~70
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=15af8b771b64d700e6449e73fdec824ab09fbc49;p=postgresql

Our version of getopt_long does not set optarg upon detecting an error, as
opposed to what other versions apparently do, so it's not safe to print an
error message.  Besides, getopt_long itself already did, so it's redundant
anyway.
---

diff --git a/src/bin/pg_ctl/pg_ctl.c b/src/bin/pg_ctl/pg_ctl.c
index 7e5c3f5906..fc5061e044 100644
--- a/src/bin/pg_ctl/pg_ctl.c
+++ b/src/bin/pg_ctl/pg_ctl.c
@@ -4,7 +4,7 @@
  *
  * Portions Copyright (c) 1996-2005, PostgreSQL Global Development Group
  *
- * $PostgreSQL: pgsql/src/bin/pg_ctl/pg_ctl.c,v 1.61.2.2 2006/01/14 16:16:08 petere Exp $
+ * $PostgreSQL: pgsql/src/bin/pg_ctl/pg_ctl.c,v 1.61.2.3 2006/06/25 04:38:00 alvherre Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -1418,7 +1418,7 @@ main(int argc, char **argv)
 					wait_set = true;
 					break;
 				default:
-					write_stderr(_("%s: invalid option %s\n"), progname, optarg);
+					/* getopt_long already issued a suitable error message */
 					do_advice();
 					exit(1);
 			}