From: Alvaro Herrera <alvherre@alvh.no-ip.org>
Date: Thu, 17 Mar 2011 15:49:38 +0000 (-0300)
Subject: Fix PL/Python memory leak involving array slices
X-Git-Tag: REL8_2_21~11
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=151e463c91e0a83a5d277dccae43a7724ffe1e76;p=postgresql

Fix PL/Python memory leak involving array slices

Report and patch from Daniel Popowich, bug #5842
(with some debugging help from Alex Hunsaker)
---

diff --git a/src/pl/plpython/plpython.c b/src/pl/plpython/plpython.c
index edcbc2a7ed..f89071ec73 100644
--- a/src/pl/plpython/plpython.c
+++ b/src/pl/plpython/plpython.c
@@ -2261,14 +2261,9 @@ PLy_result_ass_item(PyObject * arg, Py_ssize_t idx, PyObject * item)
 static PyObject *
 PLy_result_slice(PyObject * arg, Py_ssize_t lidx, Py_ssize_t hidx)
 {
-	PyObject   *rv;
 	PLyResultObject *ob = (PLyResultObject *) arg;
 
-	rv = PyList_GetSlice(ob->rows, lidx, hidx);
-	if (rv == NULL)
-		return NULL;
-	Py_INCREF(rv);
-	return rv;
+	return PyList_GetSlice(ob->rows, lidx, hidx);
 }
 
 static int