From: Leonard Chan <leonardchan@google.com>
Date: Mon, 6 May 2019 22:09:12 +0000 (+0000)
Subject: [Sema] Fix for P41774 where `ExpectNoDerefChunk` is assigned twice
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=14bb26600bd457b26ad98b82179a33069f380271;p=clang

[Sema] Fix for P41774 where `ExpectNoDerefChunk` is assigned twice

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@360089 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Sema/SemaType.cpp b/lib/Sema/SemaType.cpp
index 86bf90818c..299db7b2ed 100644
--- a/lib/Sema/SemaType.cpp
+++ b/lib/Sema/SemaType.cpp
@@ -4979,11 +4979,8 @@ static TypeSourceInfo *GetFullTypeForDeclarator(TypeProcessingState &state,
     processTypeAttrs(state, T, TAL_DeclChunk, DeclType.getAttrs());
 
     if (DeclType.Kind != DeclaratorChunk::Paren) {
-      if (ExpectNoDerefChunk) {
-        if (!IsNoDerefableChunk(DeclType))
-          S.Diag(DeclType.Loc, diag::warn_noderef_on_non_pointer_or_array);
-        ExpectNoDerefChunk = false;
-      }
+      if (ExpectNoDerefChunk && !IsNoDerefableChunk(DeclType))
+        S.Diag(DeclType.Loc, diag::warn_noderef_on_non_pointer_or_array);
 
       ExpectNoDerefChunk = state.didParseNoDeref();
     }