From: jdemeyer <jdemeyer@cage.ugent.be>
Date: Mon, 23 Jul 2018 16:41:20 +0000 (+0200)
Subject: bpo-34190: Fix reference leak in call_function() (GH-8413)
X-Git-Tag: v3.8.0a1~1335
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=147d95511f59cfdd2d522f9d736f2335457bae20;p=python

bpo-34190: Fix reference leak in call_function() (GH-8413)
---

diff --git a/Python/ceval.c b/Python/ceval.c
index 465e03012a..8f0e0e00c2 100644
--- a/Python/ceval.c
+++ b/Python/ceval.c
@@ -4576,12 +4576,15 @@ call_function(PyObject ***pp_stack, Py_ssize_t oparg, PyObject *kwnames)
                profiling. */
             PyObject *self = stack[0];
             func = Py_TYPE(func)->tp_descr_get(func, self, (PyObject*)Py_TYPE(self));
-            if (func == NULL) {
-                return NULL;
+            if (func != NULL) {
+                C_TRACE(x, _PyCFunction_FastCallKeywords(func,
+                                                         stack+1, nargs-1,
+                                                         kwnames));
+                Py_DECREF(func);
+            }
+            else {
+                x = NULL;
             }
-            C_TRACE(x, _PyCFunction_FastCallKeywords(func, stack+1, nargs-1,
-                                                     kwnames));
-            Py_DECREF(func);
         }
         else {
             x = _PyMethodDescr_FastCallKeywords(func, stack, nargs, kwnames);