From: dynaflash <dynaflashtech@gmail.com>
Date: Mon, 27 Dec 2010 16:22:21 +0000 (+0000)
Subject: MacGui: Free the source display name for the ui before re-allocating it when doing... 
X-Git-Tag: 0.9.5~20
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=142fb7d3dd6dc1971a94995a977e95f4ce5d5a0f;p=handbrake

MacGui: Free the source display name for the ui before re-allocating it when doing a queue edit rescan.
- Fixes a consistent crash when trying to edit a queue item.

git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@3714 b64f7644-9d1e-0410-96f1-a4d463321fa5
---

diff --git a/macosx/Controller.m b/macosx/Controller.m
index 720e9e2ad..78d99280d 100644
--- a/macosx/Controller.m
+++ b/macosx/Controller.m
@@ -2687,8 +2687,10 @@ fWorkingCount = 0;
     fqueueEditRescanItemNum = selectedQueueItem;
     [self writeToActivityLog: "rescanQueueItemToMainWindow: Re-scanning queue item at index:%d",fqueueEditRescanItemNum];
     applyQueueToScan = YES;
+    /* Make sure we release the display name before reassigning it */
+    [browsedSourceDisplayName release];
     /* Set the browsedSourceDisplayName for showNewScan */
-    browsedSourceDisplayName = [[QueueFileArray objectAtIndex:fqueueEditRescanItemNum] objectForKey:@"SourceName"];
+    browsedSourceDisplayName = [[[QueueFileArray objectAtIndex:fqueueEditRescanItemNum] objectForKey:@"SourceName"] retain];
     [self performScan:scanPath scanTitleNum:scanTitleNum];
 }