From: Richard Smith Date: Thu, 13 Jun 2013 22:07:02 +0000 (+0000) Subject: Avoid fallthrough in header, to allow external users of Clang libraries to X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=13f8404adee57d31863671aef3014484117492a6;p=clang Avoid fallthrough in header, to allow external users of Clang libraries to build with Clang's -Wimplicit-fallthrough warning enabled. The fallthrough was not making this code better. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@183952 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/include/clang/Sema/Sema.h b/include/clang/Sema/Sema.h index 3c4cbae790..117a519fb6 100644 --- a/include/clang/Sema/Sema.h +++ b/include/clang/Sema/Sema.h @@ -5867,10 +5867,7 @@ public: case PriorTemplateArgumentSubstitution: case DefaultTemplateArgumentChecking: - if (X.Template != Y.Template) - return false; - - // Fall through + return X.Template == Y.Template && X.TemplateArgs == Y.TemplateArgs; case DefaultTemplateArgumentInstantiation: case ExplicitTemplateArgumentSubstitution: