From: James Zern <jzern@google.com>
Date: Fri, 27 May 2016 17:33:56 +0000 (-0700)
Subject: acm_random,Rand9Signed: correct cast
X-Git-Tag: v1.6.0~104^2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=13d48c4267b4de83048602d6a8c2c30db51cf13c;p=libvpx

acm_random,Rand9Signed: correct cast

convert the random value to int16 before subtracting 256 from it; quiets
a ubsan (sanitize=integer) warning

BUG=webm:1225

Change-Id: Ibc2c5a21f30e112bd6c180f7d6a033327c38d0df
---

diff --git a/test/acm_random.h b/test/acm_random.h
index a29ced2f7..b94b6e195 100644
--- a/test/acm_random.h
+++ b/test/acm_random.h
@@ -35,7 +35,7 @@ class ACMRandom {
   int16_t Rand9Signed(void) {
     // Use 9 bits: values between 255 (0x0FF) and -256 (0x100).
     const uint32_t value = random_.Generate(512);
-    return static_cast<int16_t>(value - 256);
+    return static_cast<int16_t>(value) - 256;
   }
 
   uint8_t Rand8(void) {