From: Thomas Heller <theller@ctypes.org>
Date: Wed, 24 Sep 2008 19:01:29 +0000 (+0000)
Subject: Merged revisions 66611 via svnmerge from
X-Git-Tag: v3.0rc2~150
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=1308c26cf4cd930f3774cf6f35ae1e3c483d9718;p=python

Merged revisions 66611 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/trunk

........
  r66611 | thomas.heller | 2008-09-24 20:26:05 +0200 (Mi, 24 Sep 2008) | 3 lines

  Fix issue #3547: ctypes is confused by bitfields of varying integer types

  Reviewed by Fredrik Lundh and Skip Montanaro.
........
---

diff --git a/Lib/ctypes/test/test_bitfields.py b/Lib/ctypes/test/test_bitfields.py
index c17ba3ca33..06c4023fa2 100644
--- a/Lib/ctypes/test/test_bitfields.py
+++ b/Lib/ctypes/test/test_bitfields.py
@@ -215,6 +215,21 @@ class BitFieldTest(unittest.TestCase):
                         ("b", c_ubyte, 4)]
         self.failUnlessEqual(sizeof(X), sizeof(c_byte))
 
+    def test_mixed_4(self):
+        class X(Structure):
+            _fields_ = [("a", c_short, 4),
+                        ("b", c_short, 4),
+                        ("c", c_int, 24),
+                        ("d", c_short, 4),
+                        ("e", c_short, 4),
+                        ("f", c_int, 24)]
+        # MS compilers do NOT combine c_short and c_int into
+        # one field, gcc does.
+        if os.name in ("nt", "ce"):
+            self.failUnlessEqual(sizeof(X), sizeof(c_int) * 4)
+        else:
+            self.failUnlessEqual(sizeof(X), sizeof(c_int) * 2)
+
     def test_anon_bitfields(self):
         # anonymous bit-fields gave a strange error message
         class X(Structure):
diff --git a/Misc/NEWS b/Misc/NEWS
index ac2dda80c5..1079960036 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -20,6 +20,9 @@ Library
 
 - Bug #3884: Make the turtle module toplevel again.
 
+- Issue #3547: Fixed ctypes structures bitfields of varying integer
+  sizes.
+
 Extension Modules
 -----------------
 
diff --git a/Modules/_ctypes/cfield.c b/Modules/_ctypes/cfield.c
index beca0186d2..9040dbb135 100644
--- a/Modules/_ctypes/cfield.c
+++ b/Modules/_ctypes/cfield.c
@@ -159,7 +159,7 @@ CField_FromDesc(PyObject *desc, Py_ssize_t index,
 		break;
 
 	case EXPAND_BITFIELD:
-		/* XXX needs more */
+		*poffset += dict->size - *pfield_size/8;
 		*psize += dict->size - *pfield_size/8;
 
 		*pfield_size = dict->size * 8;