From: Peter Eisentraut <peter@eisentraut.org>
Date: Mon, 24 Jun 2019 08:39:12 +0000 (+0200)
Subject: Upgrade internal error message to external
X-Git-Tag: REL_12_BETA3~145
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=12e037e2090b1a6446376814ea0419463b02c254;p=postgresql

Upgrade internal error message to external

As part of REINDEX CONCURRENTLY, this formerly internal-only error
message becomes potentially user-visible (see regression tests), so
change from errmsg_internal() to errmsg(), and update comment.
---

diff --git a/src/backend/catalog/index.c b/src/backend/catalog/index.c
index 587b717242..bb60b23093 100644
--- a/src/backend/catalog/index.c
+++ b/src/backend/catalog/index.c
@@ -773,13 +773,13 @@ index_create(Relation heapRelation,
 				 errmsg("concurrent index creation on system catalog tables is not supported")));
 
 	/*
-	 * This case is currently not supported, but there's no way to ask for it
-	 * in the grammar anyway, so it can't happen.
+	 * This case is currently not supported.  There's no way to ask for it in
+	 * the grammar with CREATE INDEX, but it can happen with REINDEX.
 	 */
 	if (concurrent && is_exclusion)
 		ereport(ERROR,
 				(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
-				 errmsg_internal("concurrent index creation for exclusion constraints is not supported")));
+				 errmsg("concurrent index creation for exclusion constraints is not supported")));
 
 	/*
 	 * We cannot allow indexing a shared relation after initdb (because