From: Remi Gacogne Date: Fri, 1 Jun 2018 10:05:15 +0000 (+0200) Subject: rec: Use a 512-byte buffer for incoming queries instead of 1500 X-Git-Tag: dnsdist-1.3.1~37^2~1 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=12c2f2b9f70c17f584b2d517a1cb5514057134e9;p=pdns rec: Use a 512-byte buffer for incoming queries instead of 1500 --- diff --git a/pdns/pdns_recursor.cc b/pdns/pdns_recursor.cc index d469a0eb6..f3f71e5b5 100644 --- a/pdns/pdns_recursor.cc +++ b/pdns/pdns_recursor.cc @@ -2011,6 +2011,7 @@ static string* doProcessUDPQuestion(const std::string& question, const ComboAddr static void handleNewUDPQuestion(int fd, FDMultiplexer::funcparam_t& var) { ssize_t len; + static const size_t maxIncomingQuerySize = 512; static thread_local std::string data; ComboAddress fromaddr; struct msghdr msgh; @@ -2018,7 +2019,7 @@ static void handleNewUDPQuestion(int fd, FDMultiplexer::funcparam_t& var) char cbuf[256]; bool firstQuery = true; - data.resize(1500); + data.resize(maxIncomingQuerySize); fromaddr.sin6.sin6_family=AF_INET6; // this makes sure fromaddr is big enough fillMSGHdr(&msgh, &iov, cbuf, sizeof(cbuf), &data[0], data.size(), &fromaddr); diff --git a/pdns/recursordist/RECURSOR-MIB.txt b/pdns/recursordist/RECURSOR-MIB.txt index aecea2b1e..35d933ea2 100644 --- a/pdns/recursordist/RECURSOR-MIB.txt +++ b/pdns/recursordist/RECURSOR-MIB.txt @@ -771,7 +771,7 @@ truncatedDrops OBJECT-TYPE MAX-ACCESS read-only STATUS current DESCRIPTION - "Number of queries dropped because they were larger than 1500 bytes" + "Number of queries dropped because they were larger than 512 bytes" ::= { stats 93 } --- diff --git a/pdns/recursordist/docs/metrics.rst b/pdns/recursordist/docs/metrics.rst index 309fbbf8c..4ee63b45c 100644 --- a/pdns/recursordist/docs/metrics.rst +++ b/pdns/recursordist/docs/metrics.rst @@ -430,7 +430,7 @@ truncated-drops ^^^^^^^^^^^^^^^ .. versionadded:: 4.2 -questions dropped because they were larger than 1500 bytes +questions dropped because they were larger than 512 bytes unauthorized-tcp ^^^^^^^^^^^^^^^^