From: Rhodri James <rhodri@kynesim.co.uk>
Date: Thu, 27 Jul 2017 11:35:21 +0000 (+0100)
Subject: test_alloc_ext_entity_set_encoding() robust vs allocation changes
X-Git-Tag: R_2_2_3~16^2~42
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=12b3aa4fc9065ab8f01bc05be6630d96e5846aff;p=libexpat

test_alloc_ext_entity_set_encoding() robust vs allocation changes
---

diff --git a/expat/tests/runtests.c b/expat/tests/runtests.c
index e6b492ee..468f0c11 100644
--- a/expat/tests/runtests.c
+++ b/expat/tests/runtests.c
@@ -8377,17 +8377,9 @@ START_TEST(test_alloc_ext_entity_set_encoding)
         "]>\n"
         "<doc>&en;</doc>";
     int i;
-    int repeat = 0;
-#define MAX_ALLOCATION_COUNT 20
+#define MAX_ALLOCATION_COUNT 30
 
     for (i = 0; i < MAX_ALLOCATION_COUNT; i++) {
-        /* Repeat some counts to get round caching */
-        if ((i == 2 && repeat < 3) ||
-            (i == 3 && repeat < 6) ||
-            (i == 4 && repeat == 6)) {
-            i--;
-            repeat++;
-        }
         XML_SetExternalEntityRefHandler(parser,
                                         external_entity_alloc_set_encoding);
         allocation_count = i;
@@ -8395,7 +8387,9 @@ START_TEST(test_alloc_ext_entity_set_encoding)
                                     XML_TRUE) == XML_STATUS_OK)
             break;
         allocation_count = -1;
-        XML_ParserReset(parser, NULL);
+        /* See comment in test_alloc_parse_xdecl() */
+        alloc_teardown();
+        alloc_setup();
     }
     if (i == 0)
         fail("Encoding check succeeded despite failing allocator");