From: SHIRAKATA Kentaro <argrath@ub32.org>
Date: Tue, 8 Feb 2022 17:39:05 +0000 (+0900)
Subject: move null-check on savelev()
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=128966bfe181dc470a73b4c981dcbf258236ff83;p=nethack

move null-check on savelev()

Move null-check of nhfp before its first use.
---

diff --git a/src/save.c b/src/save.c
index b4bec0720..a21959888 100644
--- a/src/save.c
+++ b/src/save.c
@@ -423,6 +423,9 @@ savelev(NHFILE* nhfp, xchar lev)
 #endif
 
     g.program_state.saving++; /* even if current mode is FREEING */
+
+    if (!nhfp)
+        panic("Save on bad file!"); /* impossible */
     /*
      *  Level file contents:
      *    version info (handled by caller);
@@ -449,8 +452,6 @@ savelev(NHFILE* nhfp, xchar lev)
         if (iflags.purge_monsters)
             dmonsfree();
 
-        if (!nhfp)
-            panic("Save on bad file!"); /* impossible */
         if (lev >= 0 && lev <= maxledgerno())
             g.level_info[lev].flags |= VISITED;
         if (nhfp->structlevel)